Core/Spell: Some non-damage spells should break stealth #14765
Conversation
pjasicek
changed the title
|
doesn't it affects more spells than intended? I wonder if it can break something |
| @@ -2821,6 +2822,10 @@ void SpellMgr::LoadSpellInfoCustomAttributes() | |||
| case SPELL_AURA_POWER_BURN: | |||
| spellInfo->AttributesCu |= SPELL_ATTR0_CU_NO_INITIAL_THREAT; | |||
| break; | |||
| case SPELL_AURA_PERIODIC_DAMAGE: // DoTs like Shadow Word: Pain | |||
| spellInfo->AttributesCu |= SPELL_ATTR0_CU_NO_INITIAL_THREAT; | |||
There was a problem hiding this comment.
What do you mean ? This flag is assigned on master, I did not make this up. I only added the SPELL_ATTR0_CU_AURA_CC flag.
There was a problem hiding this comment.
If this code was on master (actually 3.3.5) the diff wouldn't show these added lines.
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/SpellMgr.cpp#L2821
Please revert this change, thanks
There was a problem hiding this comment.
Please look at this line on master:
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/SpellMgr.cpp#L2813
In my commit I only moved the "case SPELL_AURA_PERIODIC_DAMAGE:" so I would be able to add the SPELL_ATTR0_CU_AURA_CC flag. I did not add / modify any other flags besides that flag (SPELL_ATTR0_CU_AURA_CC) compared to master.
There was a problem hiding this comment.
You are correct, I'm sorry.
ghost
mentioned this pull request
|
@pjasicek which spells does this PR affect ? |
|
Any new on this? |
|
@pjasicek's account page does not show any activity after 2015-05-31. |
|
this PR modifies same lines as #14824 |
Source:
http://www.wowhead.com/forums&topic=124541.2