Core/Scripts Boss Ahune #14884
Core/Scripts Boss Ahune #14884
Conversation
|
Not sure about spawns, we don't have a proper way to make them visible only when queuing with LFG. |
|
|
||
| struct boss_ahuneAI : public BossAI | ||
| { | ||
| boss_ahuneAI(Creature* creature) : BossAI(creature, NPC_AHUNE), _summons(me) { } |
There was a problem hiding this comment.
This is wrong, the constructor asks for the "boss/encounter id" in the given instance, not the creature entry, also, SummonList is already inherited by BossAI
|
@sirikfoll: find the spells that you are missing (and anything else like proper template updates) in https://www.dropbox.com/s/d2emkc5qc9dbomw/Dump_07_03_10_12_40_50.bin.7z?dl=0 |
| me->ApplySpellImmune(0, IMMUNITY_EFFECT, SPELL_EFFECT_KNOCK_BACK_DEST, true); | ||
| } | ||
|
|
||
| void DamageTaken(Unit* who, uint32& damage) override |
|
|
||
| void DoAction(int32 action) | ||
| { | ||
| if (action = ACTION_START_EVENT) |
There was a problem hiding this comment.
You probably want == here. (Was this code tested?)
|
@sirikfoll Can you update your PR please? |
|
I'm doing some changes, based on info from the Dduarte's sniffs. Soon i'll update |
|
|
||
| void UpdateAI(uint32 diff) override | ||
| { | ||
| if (say_timer <= diff) |
There was a problem hiding this comment.
This whole thing should propably be handled as periodic ticks of http://www.wowhead.com/spell=45928 (buff that should be applied on the player who uses the gossip) also it's not supposed to be a random player but the one who activates the gossip (in go_ahune_ice_stone) and the timing is (atleast on 6.1.2) 1 sec (periodic of the buff) between those say lines.
sirikfoll
force-pushed
the
bossAhune
branch
3 times, most recently
from
3f4fc1f
to
62ac111
Compare
|
Looks good 👍 Tagged for testing. |
|
I've been using for a long time and for me is working |
| (25754,0,0,'Ahune Retreats. His defenses diminish.',41,0,100,0,0,0,24931,1,'Earthen Ring Flamecaller - EMOTE_RETREAT'), | ||
| (25754,1,0,'Ahune will soon resurface.',41,0,100,0,0,0,24932,1,'Earthen Ring Flamecaller - EMOTE_RESURFACE'), | ||
| (40446,0,0,'How DARE you! You will not stop the coming of Lord Ahune!',14,0,100,0,0,0,40437,0,'Skar\'this the Summoner'), | ||
| (25697,0,0,'The Ice Stone has melted!',14,0,100,0,0,0,24895,0,'Luma Skymother - SAY_PLAYER_1'), |
There was a problem hiding this comment.
I think this should be global announcement?
There was a problem hiding this comment.
If World announcement is correct, the value 0 between 24895 and 'Luma Skymother - SAY_PLAYER_1' needs to be set to 4 to have the Range World set for the creature_text.
There was a problem hiding this comment.
I think this was a joke, blizz had it bugged long time ago
There was a problem hiding this comment.
It was hotfixed in patch 3.0.9
There was a problem hiding this comment.
8f71950#commitcomment-15530581 from Killyana:
"Blizzard mistake we will not reproduce their bugs."
Might be meant only for specific issues, though.
|
Updated with the new Knockback immunity flag |
Implemented Midsummer Fire Festival event Boss, Ahune
|
Updated to match new ScriptLoader, btw has anyone tested this PR? '-' |
|
what about https://github.com/TrinityCore/TrinityCore/pull/14884/files#diff-c85be0be894f28c82baa42abdd9b3a2aR196 ? ill test the pr |
|
It's already fixed, next line ^^ |
|
Why this not merged yet? |
|
Hmmm. @sirikfoll does the current PR make the encounter only spawn if the event is currently going on? |
Refer to #16067 (comment) |
|
If the event(Midsummer Fire Festival) is active, everyone will be able to see the decorative GameObjects inside the instance, Ice Stone(the one used to start the encounter.) included. |
|
No, it isn't. We can merge this as soon as the PR lock is lifted (see comment by @DDuarte linked above).
|
|
u should add those conditions as well as rdf quest check. |
|
all event bosses can be done multiple times a day, but just receive rdf reward once, could you elaborate about rdf quest, not sure which you meant? |
|
rdf rewards are in fact daily quests that can be checked |
|
rdf code already checks rdf quest. Boss can be started even if rdf quest has been done for the day. Not sure what you want changed. |
|
we're talking the same thing over and over hahahahaha |
|
When you enter the instance， Fps become much lower。From 100Fps becomes 30Fps |
) (cherry picked from commit 37067ad)
I know that spawns should only appear when queuing with LFG, but that can be changed when this system is implemented, all npc's that i added to database, needs to be there to work properly.
feedback will be appreciated ^^
Issue #1516