Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [3.3.5] Core/Battlefield: Wintergrasp rewrite #21995

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
7 participants
@ccrs
Copy link
Member

commented Jun 1, 2018

What the tittle says.
tagging many issues

#6132 #6133 #8413 #8474 #8661 #9035 #9205 #9423 #19241
ref #20144

Target branch(es): 3.3.5

@Jildor

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2018

you scared me 😄

@Keader

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

Need resolve conflicts ccrs :)

@ccrs ccrs force-pushed the ccrs:wintergrasp branch from b4a7886 to 3eb38a9 Jun 1, 2018

@ccrs

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

went from 850 to 760 commit behind, slowly but steady

@ccrs ccrs force-pushed the ccrs:wintergrasp branch from e6d8193 to f37c668 Jun 1, 2018

@ccrs

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

done, but dont be too hyped, August-September is still the planned date

@AByakugans

This comment has been minimized.

Copy link

commented Sep 23, 2018

Should I test it for you? There are many changes in Language.h why is that?

@illfated

This comment has been minimized.

Copy link

commented Sep 24, 2018

@AByakugans : check the TC 3.3.5 commits from the last 3 weeks and look for anything related to chat links (invalid messages). That should explain most of it.

@Vasago

This comment has been minimized.

Copy link

commented Sep 25, 2018

b0a017d#diff-0aa27494fc202d8ac8df92999600f127

I think he meant year ago changes in file Language.h can you see it?

@TrinityCore TrinityCore deleted a comment from AByakugans Sep 25, 2018

@ccrs

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2018

I went mad, going to split this into different PRs

@ccrs ccrs closed this Sep 25, 2018

@AByakugans

This comment has been minimized.

Copy link

commented Sep 29, 2018

Ok and when we can see this new PR? I can test it for you first if you want.

@illfated

This comment has been minimized.

Copy link

commented Sep 30, 2018

@AByakugans : Patience is a virtue. Look for any small Pull Requests in the near future made by ccrs , but don't expect them to be specifically labeled "Wintergrasp" as such. Notice that he wrote

going to split this into different PRs

I read that as if he is planning on splitting it into 10 or 20 different PRs, but I don't actually know.
As long as you are watching the TrinityCore/TrinityCore repository, you should get a notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.