New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extractor.bat #23955
Update extractor.bat #23955
Conversation
More informations, nicer design, a bit updated :)
20 hours? What kind of potato machine is that |
Some Chinese oder India Computer :D Thats a random value, i saw someoe who tells that :O |
Potatoe Machines ftw! |
Remove bullshit Copy * from Buildings into vmaps. That dies vmap4assembler.exe ...
some people may want to simply extract basic files to test server instead all. |
Fine for these peoples :) |
Thanks to @MaxtorCoder to correct me. There is no Account Type BFA in Config.wtf anymore!
No, not fine for these people, your script change doesnt cover that case. In addition, i think its misleading telling this :
The extractors are used for WotLK too, i would say the majority use it for that. Telling something about account type will confuse people. |
Check last change. Already changed ;) |
Again - and @Aokromes already pointed that too - this whole change deletes the option to extract something specific :
with the change in this pr you can only extract everything and this is a bad change only to make a console window look more "pretty". |
Thanks, I was too tired to remember that you pointed that out. I will have a further look into that sub-routine call. |
Hopefully now all you wishes are in it.
Script looks good for me now. One more thing : The following was written for a reason because people came here with reporting this as a problem/bug all the time :
I wouldn't recommend removing it but it might influence your goal of making the extractor more pretty |
Has nothing todo wit my bat file. open a new ticket for this issue. this has 0 todo with the bat file. |
Small fix for vMaps only ...
More informations, nicer design, a bit updated :)
Changes proposed:
Target branch(es): 3.3.5/master
Issues addressed: Closes # (insert issue tracker number)
Tests performed: (Does it build, tested in-game, etc.)
Known issues and TODO list: (add/remove lines as needed)