Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extractor.bat #23955

Closed
wants to merge 5 commits into from
Closed

Update extractor.bat #23955

wants to merge 5 commits into from

Conversation

JustZerooo
Copy link
Contributor

@JustZerooo JustZerooo commented Dec 6, 2019

More informations, nicer design, a bit updated :)

Changes proposed:

Target branch(es): 3.3.5/master

  • 3.3.5
  • master

Issues addressed: Closes # (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.)

Known issues and TODO list: (add/remove lines as needed)

  • [ ]
  • [ ]

More informations, nicer design, a bit updated :)
@Shauren
Copy link
Member

Shauren commented Dec 6, 2019

20 hours? What kind of potato machine is that

@JustZerooo
Copy link
Contributor Author

Some Chinese oder India Computer :D Thats a random value, i saw someoe who tells that :O

@Rushor
Copy link
Contributor

Rushor commented Dec 6, 2019

Potatoe Machines ftw!

Remove bullshit Copy * from Buildings into vmaps. That dies vmap4assembler.exe ...
@Aokromes
Copy link
Member

Aokromes commented Dec 6, 2019

some people may want to simply extract basic files to test server instead all.

@JustZerooo
Copy link
Contributor Author

Fine for these peoples :)

Thanks to @MaxtorCoder to correct me. There is no Account Type BFA in Config.wtf anymore!
@Jinnaix
Copy link
Contributor

Jinnaix commented Dec 6, 2019

No, not fine for these people, your script change doesnt cover that case.

In addition, i think its misleading telling this :

ECHO       Before Continuing, PLEASE check to ensure your 
ECHO.
ECHO          Config.wtf is set at accounttype "BFA"
ECHO.
ECHO     (They should be located in: "\World of Warcraft\_retail_\WTF\")

The extractors are used for WotLK too, i would say the majority use it for that. Telling something about account type will confuse people.

@JustZerooo
Copy link
Contributor Author

Check last change. Already changed ;)

contrib/extractor.bat Outdated Show resolved Hide resolved
@Jinnaix
Copy link
Contributor

Jinnaix commented Dec 6, 2019

Again - and @Aokromes already pointed that too - this whole change deletes the option to extract something specific :

SET /P M=Type 1, 2, 3, 4 or 5 then press ENTER:
IF %M%==1 GOTO MAPS
IF %M%==2 GOTO VMAPS
IF %M%==3 GOTO MMAPS
IF %M%==4 GOTO ALL

with the change in this pr you can only extract everything and this is a bad change only to make a console window look more "pretty".

@ghost
Copy link

ghost commented Dec 6, 2019

Thanks, I was too tired to remember that you pointed that out. I will have a further look into that sub-routine call.

Hopefully now all you wishes are in it.
@JustZerooo
Copy link
Contributor Author

NgCduzJ

Now all you need ...

@Jinnaix
Copy link
Contributor

Jinnaix commented Dec 6, 2019

Script looks good for me now.

One more thing :

The following was written for a reason because people came here with reporting this as a problem/bug all the time :

ECHO The vmaps extractor output text below is intended and not an error:
ECHO ..........................................
ECHO Extracting World\Wmo\Band\Final_Stage.wmo
ECHO No such file.
ECHO Couldn't open RootWmo!!!
ECHO Done!
ECHO ..........................................
ECHO.

I wouldn't recommend removing it but it might influence your goal of making the extractor more pretty

@JustZerooo
Copy link
Contributor Author

Has nothing todo wit my bat file. open a new ticket for this issue. this has 0 todo with the bat file.

Small fix for vMaps only ...
@JustZerooo JustZerooo closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants