Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Bags: Implement sort bags #27802

Closed
wants to merge 2 commits into from
Closed

Conversation

aquadeus
Copy link
Contributor

Changes proposed:

  • Fix opcodes for sort bags

Issues addressed:

Closes #17564

Tests performed:

Tested in-game

return false;

uint16 pos = itr->second.second->GetPos();
player->SwapItem(pos, (bag << 8) | slot);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: wasn't there a macro or utility function to centralize this and avoid copy pastes in the unlikely event this math changes

@Aokromes
Copy link
Member

Aokromes commented Mar 4, 2022

Kittnz/FirestormWoD-1@63db9de checking this it looks we cannot use this.

@jackpoz
Copy link
Member

jackpoz commented Mar 4, 2022

@aquadeus trying to get an idea about this PR, was it written from scratch or was the code copied from another public GitHub project like the one linked by Aokromes ?
There are copyright implications when copying code that means we need to be aware if it was copied from somewhere else.

@Selenium
Copy link
Contributor

Selenium commented Mar 8, 2022

Note; as said on Discord, we don't care if you use the wod leaked source code, but don't say it's your work.
I can confirm this is a copy paste of the wod sources, just the code style was changed.
image

zTerragor added a commit to Legends-of-Azeroth/Legends-of-Azeroth-Legends-of-Azeroth-Shadowlands that referenced this pull request Jun 15, 2022
@aquadeus aquadeus closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup bags button freezes inventory
7 participants