New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core/Bags: Implement sort bags #27802
Conversation
return false; | ||
|
||
uint16 pos = itr->second.second->GetPos(); | ||
player->SwapItem(pos, (bag << 8) | slot); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: wasn't there a macro or utility function to centralize this and avoid copy pastes in the unlikely event this math changes
Kittnz/FirestormWoD-1@63db9de checking this it looks we cannot use this. |
@aquadeus trying to get an idea about this PR, was it written from scratch or was the code copied from another public GitHub project like the one linked by Aokromes ? |
Core/Bags: Implement sort bags TrinityCore#27802
Changes proposed:
Issues addressed:
Closes #17564
Tests performed:
Tested in-game