Core/Spells: convert some spell effects to SpellScripts #6491

Closed
wants to merge 5 commits into
from

Projects

None yet

5 participants

@joschiwald
Member
  • some cleanup/codestyle here and there
  • also correct some spellids in hexlord script and use proper headers
@tq2020
Contributor
tq2020 commented May 10, 2012

good job man.

@Kinzcool
Member

Yep Good Work.

@joschiwald
Member

how can i update this pr, that merge from tc repo will not appier in commits?

@joschiwald
Member

i will create later a clean pr, something was already pushed to master >.<

@Metal69
Metal69 commented May 22, 2012

good work!!!

joschiwald added some commits May 28, 2012
@joschiwald joschiwald Core/Spells: convert some spell effects to SpellScripts ca07f30
@joschiwald joschiwald Merge branch 'master' of github.com:joschiwald/TrinityCore into spell…
…scripts

Conflicts:
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Spells/Auras/SpellAuraEffects.cpp
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellEffects.cpp
	src/server/scripts/Spells/spell_paladin.cpp
cd7ab6f
@joschiwald joschiwald fix compile 1bfd660
@joschiwald
Member

i fix merge errors later

@QAston
Contributor
QAston commented May 28, 2012

Very good.

@joschiwald
Member

this was last commit, has anyone some suggestions to improve this pr, something what is wrong?
i create in some days a clean pr and do some tests^^

@tq2020
Contributor
tq2020 commented Jun 3, 2012

good job !!

@QAston

won't build i think. Also, please cache GetCaster() in AuraScripts to not call it 2 times.

Member

ups ^^

@QAston

AURA_EFFECT_HANDLE_CHANGE_AMOUNT_MASK means that AfterApply and AfterRemove will be called when ChangeAmount function is called, imo it should be that way because GetAmount is used in apply handler.

@QAston QAston closed this in e53b44b Jun 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment