Blood-Caked Blade fix #7831

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
8 participants
@AliveShiro
Contributor

AliveShiro commented Sep 21, 2012

Per disease on a target this spell should do 12.5% more weapon damage.
At the moment it do the 12.5% extra damage from the spells damage which only hits for 25% weapon damage. So the extra damage is only 3.125% of weapon damage. For this the damage mod should be 50% cause 50% of 25% is 12.5%.

Per disease on a target this spell should do 12.5% more weapon damage…
…. At the moment it do the 12.5% extra damage from the spells damage which only hits for 25% weapon damage. So the extra damage is only 3.125% of weapon damage. For this the damage mod should be 50% cause 50% of 25% is 12.5%.
@nerv234

This comment has been minimized.

Show comment Hide comment
@nerv234

nerv234 Sep 21, 2012

Strange but true. Yes it should deal 25% weapon damage and 12,5% weapon damage(not bcb dmg) per disease.

Strange but true. Yes it should deal 25% weapon damage and 12,5% weapon damage(not bcb dmg) per disease.

This comment has been minimized.

Show comment Hide comment
@Kr4v3n5

Kr4v3n5 Sep 21, 2012

Blood-Caked Blade :Your auto attacks have a X% chance to cause a Blood-Caked Strike, which hits for 25% weapon damage plus 12.5% for each of your diseases on the target.

Blood-Caked Blade :Your auto attacks have a X% chance to cause a Blood-Caked Strike, which hits for 25% weapon damage plus 12.5% for each of your diseases on the target.

@Star-lion

This comment has been minimized.

Show comment Hide comment
@Star-lion

Star-lion Sep 24, 2012

Contributor

Working as intended

Contributor

Star-lion commented Sep 24, 2012

Working as intended

@Star-lion Star-lion closed this Sep 24, 2012

Merge branch 'master' of git://github.com/TrinityCore/TrinityCore int…
…o blood_caked_blade

Conflicts:
	src/server/game/Spells/SpellEffects.cpp
@TBEGAMER

This comment has been minimized.

Show comment Hide comment
@TBEGAMER

TBEGAMER Mar 20, 2013

The tooltip is actually unclear. How can you be sure it adds 12.5% from that 25% weapon damage for each disease or add 12.5% weapon damage to the initial 25% for each disease?
In my opinion Blizzard made rounded numbers for a reason which is simplicity. What I'm saying is, they didn't intend to have 31.25% weapon damage Blood-Caked Strike at the end instead of 50%
Not to mention that a 6.25% total bonus from diseases is a complete joke.

If I'm proven wrong, let me claim this the only full specced talent on Wotlk with decimals.

The tooltip is actually unclear. How can you be sure it adds 12.5% from that 25% weapon damage for each disease or add 12.5% weapon damage to the initial 25% for each disease?
In my opinion Blizzard made rounded numbers for a reason which is simplicity. What I'm saying is, they didn't intend to have 31.25% weapon damage Blood-Caked Strike at the end instead of 50%
Not to mention that a 6.25% total bonus from diseases is a complete joke.

If I'm proven wrong, let me claim this the only full specced talent on Wotlk with decimals.

@Aokromes Aokromes reopened this Mar 20, 2013

@Lat89

This comment has been minimized.

Show comment Hide comment
@Lat89

Lat89 Mar 20, 2013

Dont worry, @kandera closed lots of issues for no reason. Anyway confirmed, would be nice if this PR gets pushed

Lat89 commented Mar 20, 2013

Dont worry, @kandera closed lots of issues for no reason. Anyway confirmed, would be nice if this PR gets pushed

@Star-lion

This comment has been minimized.

Show comment Hide comment
@Star-lion

Star-lion Mar 31, 2013

Contributor

except when im totally right.
((25% + (12.5% * diseases))/100) * auto attack damage

thats how it currently works.

doing the math its not working totally correct but your idea isnt working correctly either. it needs something else which im not sure of yet

Contributor

Star-lion commented Mar 31, 2013

except when im totally right.
((25% + (12.5% * diseases))/100) * auto attack damage

thats how it currently works.

doing the math its not working totally correct but your idea isnt working correctly either. it needs something else which im not sure of yet

@TBEGAMER

This comment has been minimized.

Show comment Hide comment
@TBEGAMER

TBEGAMER Mar 31, 2013

What? Why did you divide by 100?
No it's not currently working like that. Re-check #9466 please.

_1st test:_
" _1- Blood-Caked strike with no diseases on target (25% weapon damage):_
http://imageshack.us/a/img543/3591/bcbbug6.png
_Average white hit: 677_

http://imageshack.us/a/img560/5738/bcbbug5.png
_Average Blood-Caked hit: 171_

_25% of 677 = 169.25, which is very close to 171. Working._ "

That's 0 diseases and 677 white attack. Let's apply your formula on this.
((25% + (12.5% * 0))/100) * 677 = 2.5% * 677 = 16.925

It's not logical. Not at all, and it's pretty obvious. That's how a level 10 character hits.

_how it's currently working is like this:_
(25% + (25% * (12.5% * diseases))) * White hit

  • Applying the above formula on the 1st test:
    (25% + (25% * (12.5% * 0))) * 677 = 25% * 677 = 169.25 (very close to what I got in my test (171). It's an average anyway so it can never be exact)

_2nd test:_
" _2- Blood-Caked strike with 1 disease on target (37.5% weapon damage):_
http://imageshack.us/a/img560/1786/bcbbug2.png
_Average white hit: 685_

http://imageshack.us/a/img191/7254/bcbbug.png
_Average Blood-Caked hit: 192_

_37.5% of 685 = 256.875, which is not close to 192._
_12.5% of 685 = 85.625 was supposed to be the average damage increase from that 12.5% additional weapon damage, but instead, 192-(685/4) = 20.75 was the actual average increase._ "

That's 1 disease and 685 white attack.

  • Applying the formula on this 2nd test:
    (25% + (25% * (12.5% * 1))) * 685 = 28.125% * 685 = 192.65625 (192 is what I got in my test. This is closest than ever)

_3rd test:_
" _3- Blood-Caked strike with 2 diseases on target (50% weapon damage):_
http://imageshack.us/a/img62/5236/bcbbug4.png
_Average white hit: 675_

http://imageshack.us/a/img560/2924/bcbbug3.png
_Average Blood-Caked hit: 216_

_50% of 675 = 337.5, which is not close to 216_
_25% of 675 = 168.75 was supposed to be the average damage increase from that 25% additional weapon damage, but instead, 216-(675/4) = 47.25 was the actual average increase._ "

That's 2 diseases and 675 white hit.

  • Applying the formula on this 3rd test:
    (25% + (25% * (12.5% * 2))) * 675 = 31.25% * 675 = 210.9375 (close to 216)

This formula proves me (my tests) and AliveShiro (the dude who opened this PR) right.

_How it should be working (Blizzlike Formula):_
(25% + (12.5% * disease)) * White hit

  • Applying this formula on my 1st test:
    (25% + (12.5% * 0)) * 677 = 25% * 677 = 169.25
  • Applying this formula on my 2nd test:
    (25% + (12.5% * 1)) * 685 = 37.5% * 685 = 256.875
  • Applying this formula on my 3rd test:
    (25% + (12.5% * 2)) * 675 = 50% * 675 = 337.5

Check what I wrote on my tests, what the damage should be (Blizzlikely). It's exactly the same numbers I got above with the Blizzlike formula.

What? Why did you divide by 100?
No it's not currently working like that. Re-check #9466 please.

_1st test:_
" _1- Blood-Caked strike with no diseases on target (25% weapon damage):_
http://imageshack.us/a/img543/3591/bcbbug6.png
_Average white hit: 677_

http://imageshack.us/a/img560/5738/bcbbug5.png
_Average Blood-Caked hit: 171_

_25% of 677 = 169.25, which is very close to 171. Working._ "

That's 0 diseases and 677 white attack. Let's apply your formula on this.
((25% + (12.5% * 0))/100) * 677 = 2.5% * 677 = 16.925

It's not logical. Not at all, and it's pretty obvious. That's how a level 10 character hits.

_how it's currently working is like this:_
(25% + (25% * (12.5% * diseases))) * White hit

  • Applying the above formula on the 1st test:
    (25% + (25% * (12.5% * 0))) * 677 = 25% * 677 = 169.25 (very close to what I got in my test (171). It's an average anyway so it can never be exact)

_2nd test:_
" _2- Blood-Caked strike with 1 disease on target (37.5% weapon damage):_
http://imageshack.us/a/img560/1786/bcbbug2.png
_Average white hit: 685_

http://imageshack.us/a/img191/7254/bcbbug.png
_Average Blood-Caked hit: 192_

_37.5% of 685 = 256.875, which is not close to 192._
_12.5% of 685 = 85.625 was supposed to be the average damage increase from that 12.5% additional weapon damage, but instead, 192-(685/4) = 20.75 was the actual average increase._ "

That's 1 disease and 685 white attack.

  • Applying the formula on this 2nd test:
    (25% + (25% * (12.5% * 1))) * 685 = 28.125% * 685 = 192.65625 (192 is what I got in my test. This is closest than ever)

_3rd test:_
" _3- Blood-Caked strike with 2 diseases on target (50% weapon damage):_
http://imageshack.us/a/img62/5236/bcbbug4.png
_Average white hit: 675_

http://imageshack.us/a/img560/2924/bcbbug3.png
_Average Blood-Caked hit: 216_

_50% of 675 = 337.5, which is not close to 216_
_25% of 675 = 168.75 was supposed to be the average damage increase from that 25% additional weapon damage, but instead, 216-(675/4) = 47.25 was the actual average increase._ "

That's 2 diseases and 675 white hit.

  • Applying the formula on this 3rd test:
    (25% + (25% * (12.5% * 2))) * 675 = 31.25% * 675 = 210.9375 (close to 216)

This formula proves me (my tests) and AliveShiro (the dude who opened this PR) right.

_How it should be working (Blizzlike Formula):_
(25% + (12.5% * disease)) * White hit

  • Applying this formula on my 1st test:
    (25% + (12.5% * 0)) * 677 = 25% * 677 = 169.25
  • Applying this formula on my 2nd test:
    (25% + (12.5% * 1)) * 685 = 37.5% * 685 = 256.875
  • Applying this formula on my 3rd test:
    (25% + (12.5% * 2)) * 675 = 50% * 675 = 337.5

Check what I wrote on my tests, what the damage should be (Blizzlikely). It's exactly the same numbers I got above with the Blizzlike formula.

@joschiwald

This comment has been minimized.

Show comment Hide comment
@joschiwald

joschiwald Mar 31, 2013

Member

Effect 0: Id 31 (SPELL_EFFECT_WEAPON_PERCENT_DAMAGE)
BasePoints = 25
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)

the addictional damage depend on this basepoints, 50% * 25 = 12.5 -> pr seems correct

Member

joschiwald commented Mar 31, 2013

Effect 0: Id 31 (SPELL_EFFECT_WEAPON_PERCENT_DAMAGE)
BasePoints = 25
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)

the addictional damage depend on this basepoints, 50% * 25 = 12.5 -> pr seems correct

@Star-lion

This comment has been minimized.

Show comment Hide comment
@Star-lion

Star-lion Mar 31, 2013

Contributor

even if the pull request is correct it isnt currently mergable

Contributor

Star-lion commented Mar 31, 2013

even if the pull request is correct it isnt currently mergable

@AliveShiro

This comment has been minimized.

Show comment Hide comment
@AliveShiro

AliveShiro Mar 31, 2013

Contributor

why isn't it mergeable?

Contributor

AliveShiro commented Mar 31, 2013

why isn't it mergeable?

@Star-lion

This comment has been minimized.

Show comment Hide comment
@Star-lion

Star-lion Mar 31, 2013

Contributor

"This pull request cannot be automatically merged." it needs to be rebased

Contributor

Star-lion commented Mar 31, 2013

"This pull request cannot be automatically merged." it needs to be rebased

@AliveShiro

This comment has been minimized.

Show comment Hide comment
@AliveShiro

AliveShiro Mar 31, 2013

Contributor

so I have to make a new PR with actual core?

Contributor

AliveShiro commented Mar 31, 2013

so I have to make a new PR with actual core?

@Star-lion

This comment has been minimized.

Show comment Hide comment
@Star-lion

Star-lion Mar 31, 2013

Contributor

ill see what i can do

Contributor

Star-lion commented Mar 31, 2013

ill see what i can do

@Star-lion Star-lion closed this in 7fb539c Mar 31, 2013

raczman pushed a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment