Core/Player: correct SetHomebind and usage of it #8590

Merged
merged 1 commit into from Dec 9, 2012

Conversation

Projects
None yet
2 participants
Member

joschiwald commented Dec 7, 2012

Spell 53821 needs correct spell_target_position in db

@Shauren Shauren and 1 other commented on an outdated diff Dec 8, 2012

src/server/game/Handlers/NPCHandler.cpp
// send spell for homebinding (3286)
npc->CastSpell(_player, bindspell, true);
+ // todo: move it to spell handling
@Shauren

Shauren Dec 8, 2012

Member

Is this actually needed with the changes you made to Spell::EffectBind and Player::SetHomebind?

@joschiwald

joschiwald Dec 8, 2012

Member

Effect 0: Id 11 (SPELL_EFFECT_BIND)
BasePoints = 1 to 7 Multiple = 1,00
Targets (0, 0) (NO_TARGET, NO_TARGET)

so i think there is no expl target, but i do some tests more

@Shauren

Shauren Dec 8, 2012

Member

For EFFECT_BIND, if no dbc target is specified, GetUnitTarget (the first parameter passed to CastSpell) becomes the target

@joschiwald

joschiwald Dec 8, 2012

Member

i failed while testing with gm mode on xD
i'll update this pr

@Shauren Shauren added a commit that referenced this pull request Dec 9, 2012

@Shauren Shauren Merge pull request #8590 from joschiwald/homebind
Core/Player: correct SetHomebind and usage of it
b65a88e

@Shauren Shauren merged commit b65a88e into TrinityCore:master Dec 9, 2012

@Shauren Shauren added a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014

@Shauren Shauren Merge pull request #8590 from joschiwald/homebind
Core/Player: correct SetHomebind and usage of it
a718b50

@raczman raczman pushed a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014

@Kinzcool Kinzcool DB/Spell: Fixed EFFECT BIND position for "Teach: Death Gate".
Ref #8590
b60a7f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment