From ce8e73c997150751c519c9aa0816b4c3d363a248 Mon Sep 17 00:00:00 2001 From: SargeroDeV Date: Sat, 29 Apr 2023 07:12:38 -0400 Subject: [PATCH 1/3] Fixed SMSG_PLAYER_CHOICE_CLEAR struct for 10.0.7 --- .../Parsers/CharacterHandler.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs index e46c883e0a..e96cbc5a3f 100644 --- a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs +++ b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs @@ -152,6 +152,11 @@ public static void ReadPVPBracketData(Packet packet, params object[] idx) [Parser(Opcode.SMSG_PLAYER_CHOICE_CLEAR)] public static void HandleEmpty(Packet packet) { + if (ClientVersion.AddedInVersion(ClientVersionBuild.V10_0_7_48676)) // maybe this change is already present in an older build + { + packet.ReadInt32("UnkInt32"); + packet.ReadBit("UnkBit"); + } } [Parser(Opcode.SMSG_ENUM_CHARACTERS_RESULT)] From 3b7712d1b718c2e9cf8bd1ebc076d8a87c360ca5 Mon Sep 17 00:00:00 2001 From: SargeroDeV Date: Sat, 29 Apr 2023 14:54:20 -0400 Subject: [PATCH 2/3] Renamed fields --- .../Parsers/CharacterHandler.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs index e96cbc5a3f..87c82e3738 100644 --- a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs +++ b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs @@ -152,10 +152,10 @@ public static void ReadPVPBracketData(Packet packet, params object[] idx) [Parser(Opcode.SMSG_PLAYER_CHOICE_CLEAR)] public static void HandleEmpty(Packet packet) { - if (ClientVersion.AddedInVersion(ClientVersionBuild.V10_0_7_48676)) // maybe this change is already present in an older build + if (ClientVersion.AddedInVersion(ClientVersionBuild.V10_0_2_46924)) // maybe this change is already present in an older build { - packet.ReadInt32("UnkInt32"); - packet.ReadBit("UnkBit"); + packet.ReadInt32("ChoiceID"); + packet.ReadBit("Clear"); } } From 243af1d16952aa0b9172191d2cfd67c07e954103 Mon Sep 17 00:00:00 2001 From: ModoX Date: Tue, 30 May 2023 22:58:24 +0200 Subject: [PATCH 3/3] Update CharacterHandler.cs --- .../Parsers/CharacterHandler.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs index 87c82e3738..77cc1cdc9c 100644 --- a/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs +++ b/WowPacketParserModule.V9_0_1_36216/Parsers/CharacterHandler.cs @@ -150,9 +150,9 @@ public static void ReadPVPBracketData(Packet packet, params object[] idx) } [Parser(Opcode.SMSG_PLAYER_CHOICE_CLEAR)] - public static void HandleEmpty(Packet packet) + public static void HandlePlayerChoiceClear(Packet packet) { - if (ClientVersion.AddedInVersion(ClientVersionBuild.V10_0_2_46924)) // maybe this change is already present in an older build + if (ClientVersion.AddedInVersion(ClientVersionBuild.V9_2_5_43903)) { packet.ReadInt32("ChoiceID"); packet.ReadBit("Clear");