Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit image uploads if remote and local contents of graphics for type are identical #425

Merged
merged 1 commit into from Oct 16, 2018

Conversation

SUPERCILEX
Copy link
Collaborator

Fixes #423

…for type are identical

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Copy link
Contributor

@gtcompscientist gtcompscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this download the image to perform the hash?

@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Oct 11, 2018

@gtcompscientist No, it only downloads metadata (~250 bytes each).

@bhurling bhurling merged commit 9308987 into master Oct 16, 2018
@bhurling bhurling deleted the image-upload-no-op branch October 16, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants