diff --git a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md index e7124548..ec40ca26 100644 --- a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md +++ b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md @@ -16,16 +16,18 @@ Logging macro calls via a call to a procedure that does DML in an autonomous tra ## Example (bad) ``` sql -create or replace function row_generator ( - num_rows_in in number(32,0) +create or replace function row_generator( + in_num_rows in number ) return varchar2 sql_macro as begin - insert into function_calls(name, called_at, parameter_value) - values ($$PLSQL_UNIT, current_timestamp, num_rows_in); + insert into function_calls(name,called_at,parameter_value) + values ($$plsql_unit,current_timestamp,in_num_rows); commit; - - return 'select level as row_sequence from dual connect by level <= num_rows_in'; + + return 'select level as row_sequence + from dual + connect by level <= in_num_rows'; end row_generator; / ``` @@ -33,12 +35,14 @@ end row_generator; ## Example (good) ``` sql -create or replace function row_generator ( - num_rows_in in number(32,0) +create or replace function row_generator( + in_num_rows in number ) return varchar2 sql_macro as begin - return 'select level as row_sequence from dual connect by level <= num_rows_in'; + return 'select level as row_sequence + from dual + connect by level <= in_num_rows'; end row_generator; / ``` \ No newline at end of file