From ae29de0c83bd1a0395d9e7a1791eb82501101949 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Fri, 12 Aug 2022 09:28:30 +0200 Subject: [PATCH 1/3] fix syntax errors in good and bad example of G-7910 --- .../7-stored-objects/9-sql-macros/g-7910.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md index e7124548..68fedcbe 100644 --- a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md +++ b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md @@ -16,15 +16,15 @@ Logging macro calls via a call to a procedure that does DML in an autonomous tra ## Example (bad) ``` sql -create or replace function row_generator ( - num_rows_in in number(32,0) +create or replace function row_generator( + num_rows_in in number ) return varchar2 sql_macro as begin - insert into function_calls(name, called_at, parameter_value) - values ($$PLSQL_UNIT, current_timestamp, num_rows_in); + insert into function_calls(name,called_at,parameter_value) + values ($$plsql_unit,current_timestamp,num_rows_in); commit; - + return 'select level as row_sequence from dual connect by level <= num_rows_in'; end row_generator; / @@ -33,8 +33,8 @@ end row_generator; ## Example (good) ``` sql -create or replace function row_generator ( - num_rows_in in number(32,0) +create or replace function row_generator( + num_rows_in in number ) return varchar2 sql_macro as begin From 56389656256f87e447a857920a1d9a1ac78dc302 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Fri, 12 Aug 2022 09:30:56 +0200 Subject: [PATCH 2/3] rename input parameter to match our naming conventions --- .../7-stored-objects/9-sql-macros/g-7910.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md index 68fedcbe..c3b65401 100644 --- a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md +++ b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md @@ -17,15 +17,15 @@ Logging macro calls via a call to a procedure that does DML in an autonomous tra ``` sql create or replace function row_generator( - num_rows_in in number + in_num_rows in number ) return varchar2 sql_macro as begin insert into function_calls(name,called_at,parameter_value) - values ($$plsql_unit,current_timestamp,num_rows_in); + values ($$plsql_unit,current_timestamp,in_num_rows); commit; - return 'select level as row_sequence from dual connect by level <= num_rows_in'; + return 'select level as row_sequence from dual connect by level <= in_num_rows'; end row_generator; / ``` @@ -34,11 +34,11 @@ end row_generator; ``` sql create or replace function row_generator( - num_rows_in in number + in_num_rows in number ) return varchar2 sql_macro as begin - return 'select level as row_sequence from dual connect by level <= num_rows_in'; + return 'select level as row_sequence from dual connect by level <= in_num_rows'; end row_generator; / ``` \ No newline at end of file From f6fc0c9d27b68719eb2c301d9718b66d29c80d71 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Fri, 12 Aug 2022 09:33:06 +0200 Subject: [PATCH 3/3] reformatted return SQL statement to avoid horizontal scrolling in HTML result --- .../7-stored-objects/9-sql-macros/g-7910.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md index c3b65401..ec40ca26 100644 --- a/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md +++ b/docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md @@ -25,7 +25,9 @@ begin values ($$plsql_unit,current_timestamp,in_num_rows); commit; - return 'select level as row_sequence from dual connect by level <= in_num_rows'; + return 'select level as row_sequence + from dual + connect by level <= in_num_rows'; end row_generator; / ``` @@ -38,7 +40,9 @@ create or replace function row_generator( ) return varchar2 sql_macro as begin - return 'select level as row_sequence from dual connect by level <= in_num_rows'; + return 'select level as row_sequence + from dual + connect by level <= in_num_rows'; end row_generator; / ``` \ No newline at end of file