Skip to content

Commit

Permalink
build: include stubs in shared library
Browse files Browse the repository at this point in the history
This is needed for external applications that link to shared libnode.
Fixes nodejs#27431

PR-URL: nodejs#28897
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
jeroen authored and Trott committed Aug 1, 2019
1 parent 980df1c commit ed138ba
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions node.gyp
Expand Up @@ -686,6 +686,12 @@
'msvs_disabled_warnings!': [4244],

'conditions': [
[ 'node_shared=="true"', {
'sources': [
'src/node_snapshot_stub.cc',
'src/node_code_cache_stub.cc',
]
}],
[ 'node_shared=="true" and node_module_version!="" and OS!="win"', {
'product_extension': '<(shlib_suffix)',
'xcode_settings': {
Expand Down

0 comments on commit ed138ba

Please sign in to comment.