Websocket connection need to be reestablished on network failures

[ArtemKaba]

Hi everyone,

we built webhook application using example https://github.com/TrueConf/python-trueconf-bot/blob/master/examples/webhook.py

After network error or server restart we got an error
Send failed or connection closed: WS is not attached

Steps to reproduce:

# run the application with logging level INFO
python main.py
# wait for app has started
# simulate network issue like this
ip ro add <TC server> via 127.0.0.1
# wait for message "Attempting WebSocket connection"
# then remove network trouble
ip ro del <TC server> via 127.0.0.1
# the application will never talk to TC server again

Possibly you should add the reconnection logic here

python-trueconf-bot/trueconf/client/session.py

Line 41 in 3398e04

raise RuntimeError("WS is not attached")

Bot version 1.1.8

[tb-sourse]

@ArtemKaba This will be done no earlier than the release of TrueConf Server version 5.5.4

[ArtemKaba]

@tb-sourse thank you!
Currently we should to restart the application in such cases, right?
Can you tel me how to check the connection status correctly?
For now we have added k8s liveness check as a temporary solution

@app.get("/healthz")
async def health_check():
    await bot_instance.connected_event.wait()
    await bot_instance.authorized_event.wait()
    await bot_instance.server_name
    return {"status": "healthy"}

[tb-sourse]

@ArtemKaba I've added (commit 7a65f1d) web socket reconnection if the server crashes or goes offline. Try installing the beta version and provide feedback:

pip install python-trueconf-bot==1.2.0b2

[ArtemKaba]

With 1.2.0b2 version the application doesn't establish websocket connection.
Debug log stops at lines

INFO - HTTP Request: GET https://<server>/api/v4/server "HTTP/1.1 200 OK"
DEBUG - receive_response_body.started request=<Request [b'GET']>
DEBUG - receive_response_body.complete
DEBUG - response_closed.started
DEBUG - response_closed.complete
DEBUG - close.started
DEBUG - close.complete

But normally it should continue with

INFO - ⏳ Attempting WebSocket connection...
DEBUG - = connection is CONNECTING
DEBUG - > GET /websocket/chat_bot HTTP/1.1
...

[tb-sourse]

@ArtemKaba If your server version is 5.5.2, you can't use python-trueconf-bot>=1.2.0.

Check the compatibility table and let me know.

[tb-sourse]

New reconnection capabilities for down servers were added in version 1.2.0 (e5cf988). If you encounter any issues on TrueConf Server 5.5.3+, please open a new issue.