{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":394706109,"defaultBranch":"main","name":"reqwest-middleware","ownerLogin":"TrueLayer","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-08-10T16:11:36.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/21106665?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715079205.0","currentOid":""},"activityList":{"items":[{"before":"c78dfd3359732d5ab9778b8ece441906f53f29e1","after":null,"ref":"refs/heads/push-pqpnvsptkttm","pushedAt":"2024-05-07T10:53:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"fa84b1fd414d13e36479b4b176a96c954024d2e0","after":"620b089db1070d5fa127fd554ffdd2e39917070b","ref":"refs/heads/main","pushedAt":"2024-05-07T10:53:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"chore: release minor `reqwest-middleware` :rocket:","shortMessageHtmlLink":"chore: release minor <code>reqwest-middleware</code> 🚀"}},{"before":null,"after":"c78dfd3359732d5ab9778b8ece441906f53f29e1","ref":"refs/heads/push-pqpnvsptkttm","pushedAt":"2024-05-07T10:44:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"chore: release minor `reqwest-middleware` :rocket:","shortMessageHtmlLink":"chore: release minor <code>reqwest-middleware</code> 🚀"}},{"before":"d645de3b79317afb0e3ec6f23dc5deb214fa4ab8","after":null,"ref":"refs/heads/bot-272/client-builder-extend","pushedAt":"2024-05-07T10:39:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"c558e7414aa94a2b4f57be68881d666de549dc6b","after":"fa84b1fd414d13e36479b4b176a96c954024d2e0","ref":"refs/heads/main","pushedAt":"2024-05-07T10:39:49.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"[BOT-272] Function description update","shortMessageHtmlLink":"[BOT-272] Function description update"}},{"before":"c11247d37e3ec4ef6c395506cd1028cb3c42fab9","after":"d645de3b79317afb0e3ec6f23dc5deb214fa4ab8","ref":"refs/heads/bot-272/client-builder-extend","pushedAt":"2024-05-03T16:31:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefandanaita","name":"Stefan Danaita","path":"/stefandanaita","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9030768?s=80&v=4"},"commit":{"message":"[BOT-272] Function description update","shortMessageHtmlLink":"[BOT-272] Function description update"}},{"before":"371e659c567512f6eff19e089f763b5a5de28b15","after":"c11247d37e3ec4ef6c395506cd1028cb3c42fab9","ref":"refs/heads/bot-272/client-builder-extend","pushedAt":"2024-05-03T16:27:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefandanaita","name":"Stefan Danaita","path":"/stefandanaita","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9030768?s=80&v=4"},"commit":{"message":"[BOT-272] Change function from ::extend to ::from_client","shortMessageHtmlLink":"[BOT-272] Change function from ::extend to ::from_client"}},{"before":"01de1d7e0480679069df3137983dd7393e647d54","after":"371e659c567512f6eff19e089f763b5a5de28b15","ref":"refs/heads/bot-272/client-builder-extend","pushedAt":"2024-05-03T16:11:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefandanaita","name":"Stefan Danaita","path":"/stefandanaita","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9030768?s=80&v=4"},"commit":{"message":"[BOT-272] Fmt","shortMessageHtmlLink":"[BOT-272] Fmt"}},{"before":null,"after":"01de1d7e0480679069df3137983dd7393e647d54","ref":"refs/heads/bot-272/client-builder-extend","pushedAt":"2024-05-03T16:10:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stefandanaita","name":"Stefan Danaita","path":"/stefandanaita","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9030768?s=80&v=4"},"commit":{"message":"[BOT-272] ClientBuilder extend convenience function","shortMessageHtmlLink":"[BOT-272] ClientBuilder extend convenience function"}},{"before":"9ac5f691bfdb7f3b9974a48605647242fd8538ce","after":"c558e7414aa94a2b4f57be68881d666de549dc6b","ref":"refs/heads/main","pushedAt":"2024-04-26T12:58:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"main changelog entries\n\nSigned-off-by: Eirik Albrigtsen <eirik.albrigtsen@truelayer.com>","shortMessageHtmlLink":"main changelog entries"}},{"before":"1954b5c94f87906f95f98afe22bc5d105d5fb697","after":"9ac5f691bfdb7f3b9974a48605647242fd8538ce","ref":"refs/heads/main","pushedAt":"2024-04-26T12:54:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"Fix logging of `User-Agent` header in `reqwest-tracing` (#148)","shortMessageHtmlLink":"Fix logging of <code>User-Agent</code> header in <code>reqwest-tracing</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2265119513\" data-permission-text=\"Title is private\" data-url=\"https://github.com/TrueLayer/reqwest-middleware/issues/148\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/TrueLayer/reqwest-middleware/pull/148/hovercard\" href=\"https://github.com/TrueLayer/reqwest-middleware/pull/148\">#148</a>)"}},{"before":"abdf1844c37092d323683c2396b7eefda1418d3c","after":"1954b5c94f87906f95f98afe22bc5d105d5fb697","ref":"refs/heads/main","pushedAt":"2024-04-26T12:53:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"Fix missing LICENSE-* files in released crates (#147)\n\n* Fix missing LICENSE-* files in released crates\r\n\r\n* Changelog: Included license files in crates","shortMessageHtmlLink":"Fix missing LICENSE-* files in released crates (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2261587023\" data-permission-text=\"Title is private\" data-url=\"https://github.com/TrueLayer/reqwest-middleware/issues/147\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/TrueLayer/reqwest-middleware/pull/147/hovercard\" href=\"https://github.com/TrueLayer/reqwest-middleware/pull/147\">#147</a>)"}},{"before":"24c277a7634eb9c99afd1c263b62dc38b0be9d8f","after":"abdf1844c37092d323683c2396b7eefda1418d3c","ref":"refs/heads/main","pushedAt":"2024-04-11T09:16:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"feat(reqwest-retry): Configurable log level for retry event (#137)\n\n* Make retry log level configurable\r\n\r\n* Add Changelog entry\r\n\r\n* Update macro\r\n\r\n* Add comment with issue to macro\r\n\r\n* Update CHANGELOG","shortMessageHtmlLink":"feat(reqwest-retry): Configurable log level for retry event (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2219345163\" data-permission-text=\"Title is private\" data-url=\"https://github.com/TrueLayer/reqwest-middleware/issues/137\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/TrueLayer/reqwest-middleware/pull/137/hovercard\" href=\"https://github.com/TrueLayer/reqwest-middleware/pull/137\">#137</a>)"}},{"before":"e017e5c4809077c626927d518c5ac544d009b53b","after":null,"ref":"refs/heads/document-breaking-feature-removal","pushedAt":"2024-04-10T13:26:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"d2286b5e7977df08913e179dc8e0d4bb43f278cd","after":"24c277a7634eb9c99afd1c263b62dc38b0be9d8f","ref":"refs/heads/main","pushedAt":"2024-04-10T13:26:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"Document breaking feature removal for reqwest-middleware\n\nfor #144\nwill edit the release object if accepted\n\nSigned-off-by: Eirik Albrigtsen <eirik.albrigtsen@truelayer.com>","shortMessageHtmlLink":"Document breaking feature removal for reqwest-middleware"}},{"before":null,"after":"e017e5c4809077c626927d518c5ac544d009b53b","ref":"refs/heads/document-breaking-feature-removal","pushedAt":"2024-04-10T13:20:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"Document breaking feature removal for reqwest-middleware\n\nfor #144\nwill edit the release object if accepted\n\nSigned-off-by: Eirik Albrigtsen <eirik.albrigtsen@truelayer.com>","shortMessageHtmlLink":"Document breaking feature removal for reqwest-middleware"}},{"before":"90fe7d06d2ef16746dfd53305ecd10e159781d43","after":null,"ref":"refs/heads/re-introduce-reqwest-features","pushedAt":"2024-04-10T11:31:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"}},{"before":null,"after":"90fe7d06d2ef16746dfd53305ecd10e159781d43","ref":"refs/heads/re-introduce-reqwest-features","pushedAt":"2024-04-10T11:30:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tl-eirik-albrigtsen","name":"Eirik A","path":"/tl-eirik-albrigtsen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/77275738?s=80&v=4"},"commit":{"message":"Re-introduce default json + multipart features to reqwest\n\nto allow .json() etc on RequestBuilders\n\nSigned-off-by: Eirik Albrigtsen <eirik.albrigtsen@truelayer.com>","shortMessageHtmlLink":"Re-introduce default json + multipart features to reqwest"}},{"before":"d2286b5e7977df08913e179dc8e0d4bb43f278cd","after":null,"ref":"refs/heads/latest-otel-keys-rebase","pushedAt":"2024-04-10T08:58:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"94a38211f7e9fd5eec8a90f4f9ab18a758abbfd2","after":"d2286b5e7977df08913e179dc8e0d4bb43f278cd","ref":"refs/heads/main","pushedAt":"2024-04-10T08:58:19.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"fix: Remove full url from default span & `http.url` -> `url.full` in `SpanBackendWithUrl`","shortMessageHtmlLink":"fix: Remove full url from default span &amp; <code>http.url</code> -&gt; <code>url.full</code> in …"}},{"before":"2a8caf01e9d661582d4f057d8a3e9be3127e5695","after":"d2286b5e7977df08913e179dc8e0d4bb43f278cd","ref":"refs/heads/latest-otel-keys-rebase","pushedAt":"2024-04-10T08:55:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"fix: Remove full url from default span & `http.url` -> `url.full` in `SpanBackendWithUrl`","shortMessageHtmlLink":"fix: Remove full url from default span &amp; <code>http.url</code> -&gt; <code>url.full</code> in …"}},{"before":"e0dfefcb4c50b16b5a62fd0bdebf9d914cd204a3","after":null,"ref":"refs/heads/3_0","pushedAt":"2024-04-10T08:55:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"e778b7df112bcce525020c2a4784c3e151158720","after":"94a38211f7e9fd5eec8a90f4f9ab18a758abbfd2","ref":"refs/heads/main","pushedAt":"2024-04-10T08:55:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"feat!: prepare breaking release (#143)","shortMessageHtmlLink":"feat!: prepare breaking release (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2235071151\" data-permission-text=\"Title is private\" data-url=\"https://github.com/TrueLayer/reqwest-middleware/issues/143\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/TrueLayer/reqwest-middleware/pull/143/hovercard\" href=\"https://github.com/TrueLayer/reqwest-middleware/pull/143\">#143</a>)"}},{"before":"413c57793a6a5dd172cc019c2873f0b813c6a82c","after":"e0dfefcb4c50b16b5a62fd0bdebf9d914cd204a3","ref":"refs/heads/3_0","pushedAt":"2024-04-10T08:51:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"feat!: prepare breaking release","shortMessageHtmlLink":"feat!: prepare breaking release"}},{"before":"9d718e94e0682802dd779365954895197de65295","after":"413c57793a6a5dd172cc019c2873f0b813c6a82c","ref":"refs/heads/3_0","pushedAt":"2024-04-10T08:47:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"feat!: prepare breaking release","shortMessageHtmlLink":"feat!: prepare breaking release"}},{"before":null,"after":"9d718e94e0682802dd779365954895197de65295","ref":"refs/heads/3_0","pushedAt":"2024-04-10T08:47:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"feat!: prepare breaking release","shortMessageHtmlLink":"feat!: prepare breaking release"}},{"before":"55d0d0d5fcc9f6dfb0bc07783b6be78e98c774bd","after":"2a8caf01e9d661582d4f057d8a3e9be3127e5695","ref":"refs/heads/latest-otel-keys-rebase","pushedAt":"2024-04-10T08:30:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"fix: Remove full url from default span & `http.url` -> `url.full` in `SpanBackendWithUrl`","shortMessageHtmlLink":"fix: Remove full url from default span &amp; <code>http.url</code> -&gt; <code>url.full</code> in …"}},{"before":"56c3860dc64df625d523da869fa6300edc028d76","after":null,"ref":"refs/heads/revert-back-to-arc","pushedAt":"2024-04-10T08:30:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"}},{"before":"0bdb2b6ef4c955c1fe06fa101d974f88ecc2b9f3","after":"e778b7df112bcce525020c2a4784c3e151158720","ref":"refs/heads/main","pushedAt":"2024-04-10T08:30:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"chore: revert change switching from `Arc` to `Box` in public APIs (#142)\n\nfixes #139\r\n\r\nThere are other potential long term solutions listed [here](https://github.com/TrueLayer/reqwest-middleware/issues/139#issuecomment-2045946644)\r\n\r\n> I didn't put much thought into it. Internally there used to be a `Box<[Arc<dyn Middleware>]>` which is cloned about quite often.\r\n>\r\n> * https://docs.rs/reqwest-middleware/0.2.5/src/reqwest_middleware/client.rs.html#87\r\n> * https://docs.rs/reqwest-middleware/0.2.5/src/reqwest_middleware/client.rs.html#139\r\n>\r\n> Because of all the cloning, I decided to flip it to be `Arc<Box>` instead of `Box<Arc>`.\r\n>\r\n> I see three solutions here.\r\n>\r\n> 1. The one I'd lean towards is `Arc<Arc>` even if it's a bit silly, but prevents extra unnecessary allocations on each request.\r\n> 2. An alternative is to implement Middleware for Arc and then you can use the regular with(...) api. This would mean there's an extra box around your middleware\r\n> 3. Revert this particular change\r\n\r\nIn the short term, I think it's best to go with option 3. This will unblock the next release. We can consider the other options for future releasees","shortMessageHtmlLink":"chore: revert change switching from <code>Arc</code> to <code>Box</code> in public APIs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2234995368\" data-permission-text=\"Title is private\" data-url=\"https://github.com/TrueLayer/reqwest-middleware/issues/142\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/TrueLayer/reqwest-middleware/pull/142/hovercard\" href=\"https://github.com/TrueLayer/reqwest-middleware/pull/142\">#142</a>)"}},{"before":"bbb763fd8ce94361d2e4084de3fd1e6b94e636ec","after":"56c3860dc64df625d523da869fa6300edc028d76","ref":"refs/heads/revert-back-to-arc","pushedAt":"2024-04-10T08:21:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"eopb","name":"Ethan Brierley","path":"/eopb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8074468?s=80&v=4"},"commit":{"message":"chore: revert change switching from `Arc` to `Box` in public APIs\n\nfixes #139\n\nThere are other potential long term solutions listed [here](https://github.com/TrueLayer/reqwest-middleware/issues/139#issuecomment-2045946644)\n\n> I didn't put much thought into it. Internally there used to be a `Box<[Arc<dyn Middleware>]>` which is cloned about quite often.\n>\n> * https://docs.rs/reqwest-middleware/0.2.5/src/reqwest_middleware/client.rs.html#87\n> * https://docs.rs/reqwest-middleware/0.2.5/src/reqwest_middleware/client.rs.html#139\n>\n> Because of all the cloning, I decided to flip it to be `Arc<Box>` instead of `Box<Arc>`.\n>\n> I see three solutions here.\n>\n> 1. The one I'd lean towards is `Arc<Arc>` even if it's a bit silly, but prevents extra unnecessary allocations on each request.\n> 2. An alternative is to implement Middleware for Arc and then you can use the regular with(...) api. This would mean there's an extra box around your middleware\n> 3. Revert this particular change\n\nIn the short term, I think it's best to go with option 3. This will unblock the next release. We can consider the other options for future releasees","shortMessageHtmlLink":"chore: revert change switching from <code>Arc</code> to <code>Box</code> in public APIs"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQ3YRTwA","startCursor":null,"endCursor":null}},"title":"Activity · TrueLayer/reqwest-middleware"}