Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEO coin type and related stuff #158

Merged
merged 6 commits into from Mar 17, 2019

Conversation

Projects
None yet
4 participants
@ArtemGoryunov
Copy link
Contributor

ArtemGoryunov commented Mar 14, 2019

Description

Part of integration #44. Coin type and related stuff were added.

Testing instructions

Run unit tests.

Types of changes

A new PublicKeyType was added - PublicKeyType::nist256p1.
Need to define proper way to handle PublicKeyType.type, PublicKeyType.isValid based on nist256p1Size.

Checklist

  • Write unit tests. Put them in a subfolder of tests/.
  • Add relevant constants in TWCoinType, TWP2SHPrefix, TWEthereymChainID, TWHRP, etc., as necessary.
  • Return correct curve and purpose in src/Coin.cpp.
  • Implement address validation and derivation in src/Coin.cpp.
  • Implement coin configuration src/include/TWCoinTypeConfiguration.cpp.
  • Write interface header in include/TrustWalletCore and implement the interface in src/interface.
    • Address interface (if necessary).
  • Validate generated code in Android an iOS projects.

@ArtemGoryunov ArtemGoryunov force-pushed the neo-coin-type branch from 26375b0 to adde320 Mar 14, 2019

@madcake

This comment has been minimized.

Copy link
Member

madcake commented Mar 14, 2019

Tests for android and swift will be in the next PR?

@ArtemGoryunov

This comment has been minimized.

Copy link
Contributor Author

ArtemGoryunov commented Mar 14, 2019

Tests for android and swift will be in the next PR?

yes, I think integration tests will be with Signing in oncoming PR.

@alejandro-isaza
Copy link
Contributor

alejandro-isaza left a comment

Sorry I didn't see this on the first pass.

Show resolved Hide resolved src/interface/TWNEOAddress.cpp Outdated
Show resolved Hide resolved src/interface/TWNEOAddress.cpp Outdated
Show resolved Hide resolved src/PublicKey.h Outdated

@ArtemGoryunov ArtemGoryunov requested a review from alejandro-isaza Mar 14, 2019

@hewigovens
Copy link
Member

hewigovens left a comment

Could you please fix CI: src/PrivateKey.cpp:39:34: error: no member named 'nist256p1Size'

hewigovens added some commits Mar 15, 2019

@hewigovens hewigovens merged commit 0f1874e into master Mar 17, 2019

1 check passed

Wallet Core iOS #927 succeeded
Details

@hewigovens hewigovens deleted the neo-coin-type branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.