-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed np.sum in art/defences/postprocessor/gaussian_noise.py #1684
Conversation
Codecov Report
@@ Coverage Diff @@
## dev_1.10.2 #1684 +/- ##
==============================================
+ Coverage 80.16% 88.08% +7.91%
==============================================
Files 259 259
Lines 21349 21354 +5
Branches 3789 3791 +2
==============================================
+ Hits 17114 18809 +1695
+ Misses 3384 1599 -1785
- Partials 851 946 +95
|
Hi @GianlucaMega Thank you very much for you pull request, that's amazing! May I ask you for one more step, could you please sign-off the commit to pass the DCO check? Follow these steps:
|
Signed-off-by: GianlucaMega <megagianluca.mg@gmail.com>
Sorry for the inconvenience, I've fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GianlucaMega Thank you very much for your help and congratulations to your first contribution to ART! Please let me know when you are interested in working on a new project for ART.
Thank you very much @beat-buesser for the support and guidance you gave me and congratulations for ART, amazing library! |
Signed-off-By: GianlucaMega megagianluca.mg@gmail.com
Description
The GaussianNoise postprocessing defence could not handle mini-batches due to a problem with the
sums
variable, in particular with the np.sum. The original instruction has been changed intonp.sum(post_preds, axis=1, keepdims=True)
Fixes #1675
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Test Configuration:
Checklist