Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Numba an optional dependency #1884

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request make Numba an optional dependency.

Fixes #1875

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Oct 19, 2022
@beat-buesser beat-buesser added improvement Improve implementation dependencies Pull requests that update a dependency file labels Oct 19, 2022
@beat-buesser beat-buesser added this to the ART 1.12.2 milestone Oct 19, 2022
@beat-buesser beat-buesser linked an issue Oct 19, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #1884 (093cbfb) into dev_1.12.2 (3e3a438) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.12.2    #1884      +/-   ##
==============================================
- Coverage       85.90%   85.89%   -0.02%     
==============================================
  Files             248      248              
  Lines           23312    23312              
  Branches         4212     4212              
==============================================
- Hits            20027    20024       -3     
- Misses           2224     2226       +2     
- Partials         1061     1062       +1     
Impacted Files Coverage Δ
art/estimators/certification/abstain.py 90.90% <0.00%> (-9.10%) ⬇️
art/estimators/poison_mitigation/strip/strip.py 94.44% <0.00%> (-5.56%) ⬇️

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser merged commit dc29bbc into dev_1.12.2 Oct 25, 2022
@beat-buesser beat-buesser deleted the development_issue_1875 branch October 25, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make numba an optional dependency
3 participants