rewrite profile about me in react with i18next #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkvon
reviewed
Dec 22, 2018
mrkvon
reviewed
Dec 22, 2018
mrkvon
reviewed
Dec 22, 2018
mrkvon
reviewed
Dec 22, 2018
mrkvon
reviewed
Dec 22, 2018
agatatalita
force-pushed
the
user-profile-about-react
branch
2 times, most recently
from
58b5198
to
2a5f605
Compare
simison
reviewed
Feb 15, 2019
simison
reviewed
Feb 15, 2019
| {(!profile.description || profile.description === '') && | ||
| <blockquote className="profile-quote" | ||
| aria-label={t('Member has not written description about themself.')}> | ||
| “Everyone is necessarily the hero of their own life story.” |
There was a problem hiding this comment.
Let's simplify this and just not show the whole box if they didn't write anything.
We'll still need to show the area + edit link if isSelf is true.
There was a problem hiding this comment.
Oh and again good for a follow up PR, not a blocker here.
simison
reviewed
Feb 15, 2019
| }; | ||
|
|
||
| export const plainTextLength = (text) => { | ||
| return text && typeof(text) === 'string' ? String(text).replace(/ /g, ' ').replace(/<[^>]+>/gm, '').trim().length : 0; // eslint-disable-line angular/typecheck-string |
There was a problem hiding this comment.
eslint-disable-line angular/typecheck-string
Hmm, it's surprising that Angular linter is trying to lint here.
No need to change anything, I'm just noting to look into this when working again on eslint stuff: #932
mrkvon
suggested changes
Feb 15, 2019
modules/users/client/views/profile/profile-view-about.client.view.html
Outdated
Show resolved
Hide resolved
modules/users/client/views/profile/profile-view-about.client.view.html
Outdated
Show resolved
Hide resolved
modules/users/client/views/profile/profile-view-about.client.view.html
Outdated
Show resolved
Hide resolved
agatatalita
force-pushed
the
user-profile-about-react
branch
from
4a609c2
to
5a1fd14
Compare
This was referenced Feb 17, 2019
mrkvon
force-pushed
the
user-profile-about-react
branch
from
5a1fd14
to
c9e2d5f
Compare
mrkvon
approved these changes
Feb 17, 2019
|
I believe this is ready for merge. I just rebased with master and changed the |
simison
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing Instructions
/profile/:usernameand observe that everything works the same as before.i18ntranslations should work if data for translations are added topublic/locales/:languagecodefiles