Search filter: enable "online in the past 6 months" by default

[simison]

As @rumwerfer noted in #1381 (comment), "online within the last 6 months" toggle in map search wasn't on by default.

This makes 6 months default and requires people to toggle it off to get users from the past 24 months. Anyone not logged longer than that won't be visible on the map no matter how the toggle is set.

Proposed Changes

• Enable "online in the past 6 months" by default

Testing Instructions

• Open map search and filters panel
• You can either open in an incognito window to ensure you don't have filter settings in local storage saved, or you can manually delete "trustroots.search.filters" entry as seen in 2nd screenshot. Go to the "Application" tab and to "Local Storage".

By default, the toggle is on. You can also ensure from networks tab that correct "seen" value is sent (24 when the toggle is disabled, 6 months when enabled):

[sitarane]

Hey, I don't see how this:

Achieves what we want here.

Pass test on Firefox and Chrome, but I'm not sure where to look for the code changes.

[nicksellen]

I agree with @sitarane - it looks like you forgot to commit a change?

[simison]

No that's all we need. :-) The existing toggle just switches between 6 and 24 months. It's not possible to have "show everyone past 24 months". Now that 6 months is the default, we could extend the 24 to something longer that we think is still reasonable, or set it to "infinite".

Default filters are returned when no filters are saved in localStorage:

trustroots/modules/search/client/services/filters.client.service.js

Lines 23 to 27 in c39d01e

	// Look up for filters from cache.
	// Returns `defaultFilters` if nothing is found.
	let filters = locker.supported()
	? locker.get(cachePrefix, defaultFilters)
	: defaultFilters;

Here's the toggle which is now on by default since it sees 6 months vs 24 months as value:

trustroots/modules/search/client/views/search-sidebar-filters.client.view.html

Lines 38 to 45 in c39d01e

	<label tr-switch>
	<input
	type="checkbox"
	ng-model="search.onlineInPast6Months"
	ng-change="search.onSeenFilterChange()"
	/>
	Online in the past 6 months
	</label>

trustroots/modules/search/client/controllers/search.client.controller.js

Lines 150 to 161 in c39d01e

	function onSeenFilterChange() {
	vm.filters.seen.months = vm.onlineInPast6Months ? 6 : 24;
	// `vm.filters.seen` is still out of sync at this point,
	// but in next cycle after `$timeout` we have updated version.
	$timeout(function() {
	// Save new value to cache
	FiltersService.set('seen', vm.filters.seen);
	onFiltersUpdated();
	});
	}

Without the change the filter defaults to 24 months.

Unless I'm missing something?

[nicksellen]

OK, I see now :) Actually, I don't see how I didn't see before. Oh well, brains are a funny thing.

[simison]

It's a little complicated bit of code just nature of Angular.js services, hope we can simplify it with React. :-)