From bb9ed97c2482f4da387ce57abf00593a751ccd14 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Wed, 8 Aug 2018 15:48:31 +0100 Subject: [PATCH] Koenig - Allow clicks on rich-text captions to place cursor immediately refs https://github.com/TryGhost/Ghost/issues/9724 - add a `data-kg-allow-clickthrough` attribute so that it's possible to explicitly allow non-input elements to be clicked immediately when clicking on a card --- lib/koenig-editor/addon/components/koenig-card.js | 4 +++- .../addon/templates/components/koenig-basic-html-input.hbs | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/koenig-editor/addon/components/koenig-card.js b/lib/koenig-editor/addon/components/koenig-card.js index ee25adac28..0674a9f026 100644 --- a/lib/koenig-editor/addon/components/koenig-card.js +++ b/lib/koenig-editor/addon/components/koenig-card.js @@ -152,7 +152,9 @@ export default Component.extend({ // immediately when clicked let targetTagName = event.target.tagName; let allowedTagNames = ['INPUT', 'TEXTAREA']; - if (!allowedTagNames.includes(targetTagName)) { + let allowClickthrough = !!event.target.closest('[data-kg-allow-clickthrough]'); + console.log('allowClickthrough', allowClickthrough); + if (!allowedTagNames.includes(targetTagName) && !allowClickthrough) { event.preventDefault(); } diff --git a/lib/koenig-editor/addon/templates/components/koenig-basic-html-input.hbs b/lib/koenig-editor/addon/templates/components/koenig-basic-html-input.hbs index 7c19f2feec..33b8b67910 100644 --- a/lib/koenig-editor/addon/templates/components/koenig-basic-html-input.hbs +++ b/lib/koenig-editor/addon/templates/components/koenig-basic-html-input.hbs @@ -1,8 +1,9 @@ -
+