diff --git a/app/controllers/settings/design.js b/app/controllers/settings/design.js
index e850aac6e3..77df70033e 100644
--- a/app/controllers/settings/design.js
+++ b/app/controllers/settings/design.js
@@ -17,12 +17,11 @@ export default Controller.extend({
session: service(),
settings: service(),
- newNavItem: null,
-
dirtyAttributes: false,
-
+ newNavItem: null,
themes: null,
themeToDelete: null,
+
init() {
this._super(...arguments);
this.set('newNavItem', NavigationItem.create({isNew: true}));
@@ -127,8 +126,6 @@ export default Controller.extend({
activateTheme(theme) {
return theme.activate().then((theme) => {
- let themeName = theme.get('name');
-
if (!isEmpty(theme.get('warnings'))) {
this.set('themeWarnings', theme.get('warnings'));
this.set('showThemeWarningsModal', true);
@@ -138,12 +135,6 @@ export default Controller.extend({
this.set('themeErrors', theme.get('errors'));
this.set('showThemeWarningsModal', true);
}
-
- if (this.themeErrors || this.themeWarnings) {
- let message = `${themeName} activated successfully but some warnings/errors were detected.
- You are still able to use and activate the theme. Here is your report...`;
- this.set('message', message);
- }
}).catch((error) => {
if (isThemeValidationError(error)) {
let errors = error.payload.errors[0].details;
diff --git a/app/templates/components/modal-theme-warnings.hbs b/app/templates/components/modal-theme-warnings.hbs
index f38e42a440..e4e3fa2c6d 100644
--- a/app/templates/components/modal-theme-warnings.hbs
+++ b/app/templates/components/modal-theme-warnings.hbs
@@ -1,9 +1,9 @@
- {{#unless canActivate}}
- {{title}}
+ {{#unless this.canActivate}}
+ {{this.title}}
{{else}}
- {{title}} with {{#if errors}}errors{{else}}warnings{{/if}}
+ {{this.title}} with {{#if this.errors}}errors{{else}}warnings{{/if}}
{{/unless}}
{{message}}
-(Must-fix to activate theme)
(Very recommended to fix, functionality could be restricted)