Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

🦄 Improved theme validation messages #812

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

aileen
Copy link
Member

@aileen aileen commented Aug 1, 2017

closes TryGhost/Ghost#8530

  • Changed the wording for activation and uploading a theme to separate between error and warnings in the title and the body text for the modal
  • Changed the wording of "Activated successful with warnings/errors" to "Activation successful with (warnings || errors)"

closes TryGhost/Ghost#8530

- Changed the wording for activation and uploading a theme to separate between error and warnings in the title and the body text for the modal
- Changed the wording of "Activated successful with warnings/errors" to "Activation successful with (warnings || errors)"
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.041% when pulling 99250d7 on AileenCGN:theme-validation-wording into fb316a9 on TryGhost:master.

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested theme with warnings and theme with errors, the wording has changed.

@kirrg001 kirrg001 merged commit 0146936 into TryGhost:master Aug 2, 2017
@aileen aileen deleted the theme-validation-wording branch October 13, 2017 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants