/Casper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile width content overflow #464

Closed
kevinansfield opened this Issue Jul 30, 2018 · 2 comments

Comments

Assignees

@peterzimon peterzimon

Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@kevinansfield @jessehouwing @peterzimon
@kevinansfield
Contributor

kevinansfield commented Jul 30, 2018

Screenshot

img_3197

Steps to Reproduce

  1. Open https://demo.ghost.io/using-tags/ on a mobile device or using Chrome DevTools's device toolbar set to a mobile width

Technical details

  • Casper Version: 2.4.0
  • Ghost Version: 1.25.2

@kevinansfield kevinansfield added the bug label Jul 30, 2018

@kevinansfield kevinansfield assigned peterzimon Jul 30, 2018

peterzimon added a commit that referenced this issue Jul 30, 2018

@peterzimon
refs. #464 
- fixing content max-width for 1.0 posts (i.e. `kg-markdown-card` wrapper)
e83ffe9

@peterzimon peterzimon referenced this issue Jul 30, 2018

Merged

Fixing content overflow for 1.0 posts on mobile #465

@kevinansfield kevinansfield closed this in f67caab Jul 30, 2018

@jessehouwing

This comment has been minimized.

Show comment
Hide comment
@jessehouwing

jessehouwing Jul 31, 2018

Not entirely fixed it seems:
image

When there is a long code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element- the line doesn't wrap.

Sample page: https://jessehouwing.net/visual-studio-2017-merge-tool-in-tower/

jessehouwing commented Jul 31, 2018 •
edited
Edited 1 time
  • @jessehouwing jessehouwing edited Jul 31, 2018 (most recent)
  • @jessehouwing jessehouwing created Jul 31, 2018

Not entirely fixed it seems:
image

When there is a long code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element-code-element- the line doesn't wrap.

Sample page: https://jessehouwing.net/visual-studio-2017-merge-tool-in-tower/
@kevinansfield

This comment has been minimized.

Show comment
Hide comment
@kevinansfield

kevinansfield Jul 31, 2018

Contributor

Hey @jessehouwing 👋 Good catch! 😄 This appears to be a different issue, one that was around before the issue this PR addressed. I've opened a new issue for it here #466
Contributor

kevinansfield commented Jul 31, 2018

Hey @jessehouwing 👋 Good catch! 😄 This appears to be a different issue, one that was around before the issue this PR addressed. I've opened a new issue for it here #466

ryan-jan pushed a commit to ryan-jan/Casper-RyanJan that referenced this issue Aug 26, 2018

@peterzimon @kevinansfield
🐛 Fixed content overflow on mobile 
closes TryGhost#464
- setting max-width of `kg-markdown-card` wrapper that is still used by non-Koenig posts
00167ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment