This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Rename "offset" to "blogTimezone" #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Ghost#6941 (comment) - `blogTimezone` and `timezone` better reflect their values (a string representing a timezone in the format `Europe/Dublin`) than `offset` which suggests a fixed value
| return verifyTimeStamp(value ? moment(value).tz(offset).format(displayDateFormat) : ''); | ||
| function formatDate(value, timezone) { | ||
| // we output the date adjusted to the blog timezone selected in settings | ||
| return verifyTimeStamp(value ? moment(value).tz(timezone).format(displayDateFormat) : ''); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#6941 (comment)
blogTimezoneandtimezonebetter reflect their values (a string representing a timezone in the formatEurope/Dublin) thanoffsetwhich suggests a fixed valueThis hopefully makes things a little easier to follow for now. Once the synchronous
settingsservice is ready I imagine thetimeZoneservice and it'stimeZone.blogTimezonewill disappear and it'll be replaced withsettings.activeTimezone.