Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris/Illumos (sunos x64) broken in 1.7.x #706

Closed
1 of 2 tasks
hadret opened this issue Apr 20, 2018 · 4 comments
Closed
1 of 2 tasks

Solaris/Illumos (sunos x64) broken in 1.7.x #706

hadret opened this issue Apr 20, 2018 · 4 comments

Comments

@hadret
Copy link
Member

hadret commented Apr 20, 2018

This issue is a

  • Bug Report
  • Feature Request

Summary

I understand this is not a recommended stack -- that being said, ghost-cli and ghost itself did work perfectly fine on Solaris/Illumos (sunos x64) until the most recent changes. The problem lies in usage/new dependency on systeminformation that is not supporting sunos. This has not been a problem on the current ghost-cli version I'm running on this platform (1.5.1).

Steps to Reproduce (for a bug report)

  1. npm install -g ghost-cli@latest on Solaris/Illumos OS

This has been working perfectly fine until the most recent release of ghost-cli 1.7.x.

Log file (for a bug report)

npm ERR! SunOS 5.11
npm ERR! argv "/opt/local/bin/node" "/opt/local/bin/npm" "install" "-g" "ghost-cli@latest"
npm ERR! node v6.12.2
npm ERR! npm  v3.10.10
npm ERR! code EBADPLATFORM

npm ERR! notsup Unsupported platform for systeminformation@3.37.8: wanted {"os":"darwin,linux,win32,freebsd,openbsd","arch":"any"} (current: {"os":"sunos","arch":"x64"})
npm ERR! notsup Valid OS:    darwin,linux,win32,freebsd,openbsd
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   sunos
npm ERR! notsup Actual Arch: x64

npm ERR! Please include the following file with any support request:
npm ERR!     /home/admin/npm-debug.log

Technical details (for a bug report)

This is automatically output by Ghost-CLI if an error occurs, please copy & paste:

  • OS: SunOS 5.11
  • Node Version: 6.12.2
  • Ghost-CLI Version: 1.5.1

I created a bug report on the systeminformation side sebhildebrandt/systeminformation#126. For the time being I was hoping though that this dependency could be dropped maybe?

@sebhildebrandt
Copy link

I will try to implement basic SunOS support for the systeminformation package. Hope I will be able to provide a first version next week.

@sebhildebrandt
Copy link

I added basic SunOS support for systeminformation. The used functionality for Ghost-CLI should now work when using an updated dependency version 3.39.0 for systeminformation.

aileen added a commit to aileen/Ghost-CLI that referenced this issue Apr 30, 2018
@aileen
Copy link
Member

aileen commented May 2, 2018

Closing, as systeminformation was updated with d43efd7 and this issue should be solved with it.

@aileen aileen closed this as completed May 2, 2018
@hadret
Copy link
Member Author

hadret commented May 2, 2018

Indeed it is, thank you both! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants