New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port-polling.js to allow Ghost-CLI to work on slower devices (Raspberry Pi et al). #638

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@raspberrycoulis
Copy link
Contributor

raspberrycoulis commented Feb 9, 2018

Doubled timeout to allow the CLI tool to run on slower devices, like the Raspberry Pi. Whilst not officially supported, Raspbian Stretch does work with the new Ghost CLI tool with a few tweaks. Recent changes to the CLI tool (this check) caused the install / update process to fail due to the timeout check. Discussed with Vilkas Potluri in the Slack Help channel (under my username GhostPi) and this works. Tested on 4 blogs hosted on my own Raspberry Pi. Linked to issue opened (and subsequently closed) found here: TryGhost/Ghost#9447 (comment)

Update port-polling.js
Doubled timeout to allow the CLI tool to run on slower devices, like the Raspberry Pi. Whilst not officially supported, Raspbian Stretch does work with the new Ghost CLI tool with a few tweaks. Recent changes to the CLI tool (this check) caused the install / update process to fail due to the timeout check. Discussed with Vilkas Potluri in the Slack Help channel (under my username @ghostpi) and this works. Tested on 4 blogs hosted on my own Raspberry Pi. Linked to issue opened (and subsequently closed) found here: TryGhost/Ghost#9447 (comment)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 221985e on raspberrycoulis:master into f836464 on TryGhost:master.

@acburdine
Copy link
Member

acburdine left a comment

lgtm 👍

@acburdine acburdine merged commit 8804372 into TryGhost:master Feb 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

vikaspotluri123 added a commit to vikaspotluri123/Ghost-CLI that referenced this pull request Feb 18, 2018

fix(port-polling): increase port polling timeout (TryGhost#638)
refs TryGhost/Ghost#9447
- Doubled timeout to allow the CLI tool to run on slower devices, like the Raspberry Pi. Whilst not officially supported, Raspbian Stretch does work with the new Ghost CLI tool with a few tweaks. Recent changes to the CLI tool (this check) caused the install / update process to fail due to the timeout check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment