Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed API dependency from mailer and api/mail
Fixes #2836. * Mailer now only handles sending email and initializing settings. Instead of adding new notifications there, it just sets flags on its own object. * Mailer now checks for the presence of "to". If there is none, it fails. You should really pass a full mail object complete with "to", "subject" and "html", otherwise it's partial content. * Therefore Mail API doesn't check for the existence of the "to", and doesn't get the email from settings and substitute that * index.js now has a method that adds the notifications. I figured adding those THERE is probably better than individually in every module. It is, as the comments say, can be made extensible
- Loading branch information
Showing
2 changed files
with
48 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters