Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: TryGhost/Ghost
base: v5.42.0
Choose a base ref
head repository: TryGhost/Ghost
compare: v5.42.1
Choose a head ref
  • 5 commits
  • 7 files changed
  • 3 contributors

Commits on Apr 7, 2023

  1. Added fetchAndDownloadFile method to utils service

    The existing approach didn't expose when the download was complete.
    
    By fetching the file upfront and downloading from a blob we can better
    estimate when the download is complete because we load the file in
    memory, and then download from there.
    
    The promise resolves after the file is in memory, so the delay between
    the promise resolving and the file actually being downloaded is a lot
    shorter, and based on the size of the file.
    allouis committed Apr 7, 2023
  2. Updated the posts export button to be a GhTaskButton

    refs TryGhost/Team#2935
    
    This allows us to track the state with a loading spinner and a
    success/error message on completion. This is expecially important for
    larger sites where the download can take a long time, and users are
    unsure if something is happening.
    allouis committed Apr 7, 2023
  3. Limited post export size to 1000 posts

    refs TryGhost/Team#2936
    
    We want to make sure that downloads complete in a reasonable number of
    time, and the simplest way to do that is to cap the size of the file.
    allouis committed Apr 7, 2023
  4. 🔒 Fixed path traversal issue in theme files

    refs TryGhost/Team#2843
    
    - Using encoded path traversal characters in URL's path allowed to fetch
      any file within active theme's folder, which is disallowed
    - credits to: fuomag9 https://kiwi.fuo.fi/@fuomag9
    daniellockyer committed Apr 7, 2023
  5. v5.42.1

    github-actions[bot] committed Apr 7, 2023