New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post URL is returning 404 after publishing #10356

Closed
gargol opened this Issue Jan 9, 2019 · 8 comments

Comments

Projects
None yet
5 participants
@gargol
Copy link
Contributor

gargol commented Jan 9, 2019

Issue Summary

The issue occurs after publishing a post. After clicking on "Published! View post" link it leads to 404 page.

To Reproduce

  1. Create a post
  2. Publish the post
  3. Click on the link in 'Published' popup in down left corner
  4. Link opens a page with 404

Clicking on the link should lead to published post instead.

Additionally the response that comes back from the server when publishing a post contains a field with wrong URL:

url: "http://ghost.local/404/"

Technical details:

  • Ghost Version: 2.10.1
  • Node Version: 8.11.4
  • Browser/OS: Chrome 71 / Ubuntu 18.04
  • Database: MySQL 5.7.24

@gargol gargol self-assigned this Jan 9, 2019

@gargol

This comment has been minimized.

Copy link
Contributor Author

gargol commented Jan 9, 2019

The issue has been prioritized and is being worked on asap.

@kirrg001

This comment has been minimized.

Copy link
Contributor

kirrg001 commented Jan 10, 2019

The underlying problem:

  1. PUT request to publish a post comes in
  2. on saving method in model is being executed
  3. on saving triggers Ghost events
    3.1. saving of the post finishes and the response is handed back (without finding url in url cache)
    3.2. url service repopulates the cache with new values
  4. at this point 3.1 is done as we don't have anything listening to url cache updates. ideally we'd want to be notified or be sure that 3.2 is finished before 3.1
@pascalandy

This comment has been minimized.

Copy link

pascalandy commented Jan 11, 2019

Hi, with this bug, should we wait before upgrading to 2.10.1? I think we should. If so here is my question:

Is there an official communication channel to let people know about the fact we should wait before upgrading to X version?

Thanks!

@kevinansfield

This comment has been minimized.

Copy link
Contributor

kevinansfield commented Jan 11, 2019

@pascalandy the only practical problem arising from this bug is that the "View post" link in the "Published post" popup in the bottom left of the screen after publishing points at a 404. There are only a few milliseconds where an API request for a recently published post could have the wrong url field and it doesn't affect the front-end at all so the issue is not considered critical but is high-priority.

Whether you upgrade or not is up to you. If we discover a truly critical bug then a followup release will usually be made very quickly and the release notes will call out any problematic versions.

@gargol

This comment has been minimized.

Copy link
Contributor Author

gargol commented Jan 11, 2019

Closed via #10361

@gargol gargol closed this Jan 11, 2019

@pascalandy

This comment has been minimized.

Copy link

pascalandy commented Jan 11, 2019

Thank for the answer, this is where it was not clear not me:

so the issue is not considered critical but is high-priority.

@bershatsky

This comment has been minimized.

Copy link

bershatsky commented Jan 11, 2019

I too have this issue.

@bershatsky

This comment has been minimized.

Copy link

bershatsky commented Jan 11, 2019

If you hit publish a second time, it goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment