New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Ghost Split Screen Editor #1294

Closed
ErisDS opened this Issue Oct 27, 2013 · 5 comments

Comments

Projects
None yet
5 participants
@ErisDS
Member

ErisDS commented Oct 27, 2013

The following issue is here as a way to collect together and organise the issues raised against the existing Ghost split screen editor.

The issues fall into 3 broad categories:

  1. Markdown conversion bugs - mostly the result of issues in Showdown, which converts the markdown in the left screen into HTML in the right screen.
  2. Editor functionality issues - largely caused by the complexity of CodeMirror - include problems with editing on small devices etc.
  3. Syncing issues - problems with scrolling, flickering, and other problems with maintaining the two panels.

Below is a collection of known issues.

  1. Markdown conversion
  • #644 Markdown output jumps around like a monkey on crack when writing in italics (closed: wontfix- requires new editor / plugin)
  • #974 Markdown bug: no new line inserted when quotes are used (closed: fixed)
  • #985 Set "title" attribute for images from markdown (closed: wontfix )
  • #1045 Code gets escaped (closed: fixed)
  • #1113 Allow multiple underscores like: _________ (closed: fixed)
  • #1909 Markdown editor ** bold editor text (closed: wontfix)
  • #2664 Syntax highlighting bug within the editor (closed: wontfix)
  • #2293 Support for markdown reference link syntax as well as inline syntax (closed: wontfix )
  • #1318 Markdown footnotes (Enhancement) (closed: wontfix)
  • #1670 Allow Markdown Tables (closed: wontfix)
  • #3203 Multiple parentheses in link breaks markdown
  • #1501 Hyperlinks containing underscores are processed as italics
  • #2304 Bug: apostrophe in image alt tag causes word count to be incorrect
  • #2093 Markdown issues with new lines.
  1. Editor functionality
  • #553 Restoring form-data on editor panel (closed: fixed)
  • #960 Mobile Editing is buggered in iOS 7 (closed: fixed)
  • #1007 Unexpected behaviour in editor with home / end keys (closed: fixed)
  • #1240 Browser spellcheck doesn't work with CodeMirror (closed: wontfix - requires new editor / plugin)
  • #1295 CodeMirror: Cursor does not always appear in the right place (closed: browser bug
  • #1296 CodeMirror: Very hard to edit via mobile (not just iOS7) (closed: fixed - mobile version of editor in place)
  • #2245 Wrong cursor position in Markdown editor for Unicode (closed: wontfix)
  • #1007 Unexpected behaviour in editor with home / end keys (closed: wontfix)
  • #2570 Bugs with the touchscreen editor. (closed: mostly fixed)
  • #2703 about the content (closed: fixed)
  • #3577 Images not detected in lists (closed: wontfix)
  • #1299 No spaces when typing (closed: fixed)
  • #2371 Character "„" doesn't show on markdown editor (closed: fixed)
  1. Syncing issues

Many of these appear to be duplicates / different incarnations of the same general problem

  • #22 Advanced scroll features (closed: wontfix)
  • #535 Editor scrolling gets stuck when typing lots of text (closed: fixed)
  • #958 Fucked up scrolling behaviour when typing (closed: fixed)
  • #959 Weird markdown syntax highlighting (closed: wontfix)
  • #1031 Images in preview pane flicker as you type (closed: wontfix)
  • #481 Editor UI - Scroll events are not smooth (closed: wontfix)
  • #1030 Point in preview pane corresponding to the cursor can be offscreen when typing
  • #3524 Bug: Mobile Editor - Left Side Not Always Scrollable

Many of these are closed as won't fix, because they cannot be resolved without fundamental changes.

Short term, some of the category 1 markdown bugs are fixable by tweaking our extension of Showdown. It may be possible to vastly improve behaviour by maintaining our own fork of Showdown for the short/mid term.

Long term, we will be replacing the editor with an entirely new component which will look and function very differently to the existing editor.

The following wontfix issues will be fixed by dropping CodeMirror (#4373):

  • #1240 Browser spellcheck doesn't work with CodeMirror
  • #959 Weird markdown syntax highlighting
  • #1909 Markdown editor ** bold editor text
  • #2664 Syntax highlighting bug within the editor
  • #2245 Wrong cursor position in Markdown editor for Unicode
  • #1007 Unexpected behaviour in editor with home / end keys
@halfdan

This comment has been minimized.

Show comment
Hide comment
@halfdan

halfdan Mar 9, 2014

Member

Just found this: http://epiceditor.com/

Member

halfdan commented Mar 9, 2014

Just found this: http://epiceditor.com/

@nicoburns

This comment has been minimized.

Show comment
Hide comment
@nicoburns

nicoburns Jun 12, 2014

Collaborator

https://stackedit.io/ has a nice editor which is somewhat similar to Ghost's...

Collaborator

nicoburns commented Jun 12, 2014

https://stackedit.io/ has a nice editor which is somewhat similar to Ghost's...

@ErisDS ErisDS added the editor label Aug 16, 2014

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Aug 18, 2014

Member

I believe this is as done as its going to be before editor rewrite, and can be closed

Member

JohnONolan commented Aug 18, 2014

I believe this is as done as its going to be before editor rewrite, and can be closed

@foxylad

This comment has been minimized.

Show comment
Hide comment
@foxylad

foxylad Sep 5, 2014

Love everything about Ghost, but no spellcheck... no go.

I imagine you're loathe to switch to another markdown editor since each time you do, it will throw up a whole new set of issues. But you've been promising spellcheck for at least a year now, and I think you owe it to your customers to deliver. I'd suggest that this should be your number one priority.

foxylad commented Sep 5, 2014

Love everything about Ghost, but no spellcheck... no go.

I imagine you're loathe to switch to another markdown editor since each time you do, it will throw up a whole new set of issues. But you've been promising spellcheck for at least a year now, and I think you owe it to your customers to deliver. I'd suggest that this should be your number one priority.

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS May 19, 2015

Member

I'm going to close this issue now. The majority of the horrible bugs with the editor itself were killed as part of removing CodeMirror (#4368), and the spec-breaking markdown issues which can be fixed are being ironed out as part of separate issues and the PR #5167. Everything and anything else we do with the editor will be part of post-Zelda (admin UI design refresh #5273) changes, which will get their own issues.

Member

ErisDS commented May 19, 2015

I'm going to close this issue now. The majority of the horrible bugs with the editor itself were killed as part of removing CodeMirror (#4368), and the spec-breaking markdown issues which can be fixed are being ironed out as part of separate issues and the PR #5167. Everything and anything else we do with the editor will be part of post-Zelda (admin UI design refresh #5273) changes, which will get their own issues.

@ErisDS ErisDS closed this May 19, 2015

@ErisDS ErisDS removed this from the Future Backlog milestone May 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment