Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "The team at X" from transactional emails #13613

Closed
JohnONolan opened this issue Oct 15, 2021 · 7 comments
Closed

Remove "The team at X" from transactional emails #13613

JohnONolan opened this issue Oct 15, 2021 · 7 comments
Labels
good first issue [triage] Start here if you've never contributed before. Hacktoberfest Issues suitable for hacktoberfest participants

Comments

@JohnONolan
Copy link
Member

JohnONolan commented Oct 15, 2021

Several site owners have complained about the language used in our transactional emails, which have a sign-off that reads:

The team at $site.title

This is a confusing message coming from solo-creators who have no team, and publish under their own name.

The sign-off is non-essential, so we'd like to just remove this line completely from the emails where it appears:

https://github.com/TryGhost/Ghost/search?q=%22The+team+at%22

CleanShot 2021-10-15 at 14 47 38@2x
@JohnONolan JohnONolan added good first issue [triage] Start here if you've never contributed before. Hacktoberfest Issues suitable for hacktoberfest participants labels Oct 15, 2021
@fcoiuri
Copy link
Contributor

fcoiuri commented Oct 15, 2021

Hi, can I work on this issue?

@JohnONolan
Copy link
Member Author

JohnONolan commented Oct 15, 2021

@fcoiuri For sure! Just open a PR :)

@fcoiuri fcoiuri mentioned this issue Oct 15, 2021
Merged
3 tasks
@shaikhfaizan7
Copy link

shaikhfaizan7 commented Oct 16, 2021

Can I work on this ???

@Sen-442b
Copy link

Sen-442b commented Oct 20, 2021

Though I haven't been assigned this issue but I submitted a pull request regardless, kindly consider checking that out .

@joemcgee4151986
Copy link

joemcgee4151986 commented Oct 21, 2021

Mind if I can work on this?

@ErisDS ErisDS closed this as completed in 7debc28 Oct 21, 2021
@ErisDS
Copy link
Member

ErisDS commented Oct 21, 2021

The work was completed by @fcoiuri, thank you 🙂

@JohnONolan
Copy link
Member Author

JohnONolan commented Oct 26, 2021

Great work @fcoiuri ! Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue [triage] Start here if you've never contributed before. Hacktoberfest Issues suitable for hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ErisDS @JohnONolan @joemcgee4151986 @fcoiuri @Sen-442b @shaikhfaizan7