Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: User email address hide publicly #2330

Closed
kezzbracey opened this issue Mar 4, 2014 · 5 comments · Fixed by #3442
Closed

Feature Request: User email address hide publicly #2330

kezzbracey opened this issue Mar 4, 2014 · 5 comments · Fixed by #3442
Assignees

Comments

@kezzbracey
Copy link
Contributor

At the moment we have the ability to user {{author.email}} in themes, which is great for creating a mailto: link if users would like it to be there.

However if a user doesn't want their email address public and the theme they use shows it, they can't delete their address from the user settings field as it's required for notifications.

As such the options at present are:

  • Themes don't use the {{author.email}} tag to ensure privacy
  • Themes do use the tag and users have to delete it if they don't want their email shown

It would be great if there were an option in the admin settings UI that a user could switch to determine whether a theme could access their email address or not.

That way themes could safely use the {{author.email}} tag to create mailto: links for those who want them, without comprimising the privacy of those who don't.

@ErisDS ErisDS added this to the 0.6 milestone Mar 4, 2014
sebgie added a commit to sebgie/Ghost that referenced this issue Jun 12, 2014
closes TryGhost#2354
refs TryGhost#1641

- added addUnique()
- added dropUnique()
- added addColumn() -> needed for TryGhost#2330
- dropColumn() is missing due to lack of knex support
- further cleanup of the migrations module
@ErisDS
Copy link
Member

ErisDS commented Jun 25, 2014

After some thought, and considering our default position is "don't add a setting unless you have to", I think we need to just remove email from being accessible by themes all together.

@kezzbracey
Copy link
Contributor Author

Sounds like a better choice. If people want to provide an email address they can always do it via a page.

@halfdan
Copy link
Contributor

halfdan commented Jun 25, 2014

Not sure - I can totally see themes using author.email when we have user pages and e.g. larger websites want to show author/editor contact details.

@ErisDS
Copy link
Member

ErisDS commented Jun 25, 2014

Apps will let people define all the custom fields they like, but we need to be pro privacy. We should make sure that {{author.email}} doesn't create an error, but I really don't think it's used by many themes.

@kezzbracey
Copy link
Contributor Author

Yes I think you're right given spam issues.

My guess is that even if people do want to offer the ability to be contacted they'll prefer third party contact forms with captcha or social media links so emails don't get scraped by bots.

@ErisDS ErisDS changed the title Feature Request: User email address, admin option to hide publicly Feature Request: User email address hide publicly Jul 1, 2014
@ErisDS ErisDS mentioned this issue Jul 1, 2014
26 tasks
sebgie added a commit to sebgie/Ghost that referenced this issue Jul 29, 2014
closes TryGhost#2330
- added deletion email address from post.author in front end
- updated tests
- with some refactoring this could be done on API level
@ErisDS ErisDS added the themes label Aug 6, 2014
ErisDS added a commit to ErisDS/Ghost that referenced this issue Apr 17, 2015
refs TryGhost#2330

- Pass through `options` to all toJSON calls on posts, tags, and users
- Use options.context.user to determine whether it's OK to return user.email
- Remove author.email handling code from frontend.js
ErisDS added a commit to ErisDS/Ghost that referenced this issue Apr 17, 2015
refs TryGhost#2330

- Pass through `options` to all toJSON calls on posts, tags, and users
- Use options.context.user to determine whether it's OK to return user.email
- Remove author.email handling code from frontend.js
ErisDS added a commit to ErisDS/Ghost that referenced this issue Apr 17, 2015
refs TryGhost#2330

- Pass through `options` to all toJSON calls on posts, tags, and users
- Use options.context.user to determine whether it's OK to return user.email
- Remove author.email handling code from frontend.js
tigefa4u pushed a commit to tigefa4u/Ghost that referenced this issue Aug 3, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants