[Feature] Tag Management #4248

Closed
novaugust opened this Issue Oct 7, 2014 · 14 comments

Comments

Projects
None yet
6 participants
@novaugust
Member

novaugust commented Oct 7, 2014

Here's the original UI issue: #3926 , and the markup was added in #4171. The big picture vision for tags is written up in the Tag 101 document on the wiki, which covers tonnes of advanced features.


In order to ship tag management we need to deliver a minimum working version. Here's what we think it should look like:

screenshot of simple tag list

This list shows each tag in a list. The list needs to have infinite scroll applied to it, much the same as the users or posts list. The number on the right is the number of posts that the tag is associated with.

Clicking on any one of the tags in the list will open up the 'tag settings menu' or TSM :)

screenshot of edit screen

This allows for editing the tag name, slug, description, and post cover image. There is also a meta data screen the same as in the post settings menu. Editing the slug updates a live URL preview.

This screen should only appear for users with the role 'Editor' or higher.

Development How-To

The tags UI is hidden behind a feature flag! To see, use, and develop with the tags settings you must set tagsUI: true in the development object of your config.js.

E.g:

development: {
    url: 'http://localhost:2368',
    tagsUI: true,
    ...

Server Side

Tag API

  • Full BREAD baby! (Currently, only Browse is implemented) #4263
  • Output number of posts associated with tag (issue #4521)
  • Ensure API permissions are correct

Client Side

  • Add new page to settings #4260
  • BREAD (WIP PR #4489)
  • Add infinite scroll (done in PR #4489)
  • Add autosave and remove save button (issue #4517)
  • Add the cover image (issue #4506)
  • Add number of posts (issue #4683, requires #4521)
  • Permissions - Only editors and up
  • Add meta data screen (issue #4509)
  • Fixup the delete flow (issue #4633)
  • Dynamic URL preview (issue #4499)
  • Dry up the code (issue #4642)

Themes

  • Use tag meta data on tag archive pages (issue #4677)
  • Make sure {{image}} helper works for tags (issue #4506)

Bugs & Improvements

  • Bug: Settings menu doesn't close on transition bug ember (issue #4504)
  • UX Issue: Tag management list needs larger click area ember (issue #4505)
  • Tag Management: Functional Tests (issue #4507)
  • Enforcing uniqueness of tag names (issue #4687)

See Tag 101 for a description of advanced features we'll be adding later like hierarchy, visibility and search.

@novaugust

This comment has been minimized.

Show comment
Hide comment
@novaugust

novaugust Oct 7, 2014

Member

The UI suggests stuff I'm not sure is implemented on the backend yet - things like tag hierarchy, and tags having customizable slugs. Can anyone tell me whether I need to open another issue for that? @halfdan @sebgie @ErisDS

There's also the idea that a tag should report back how many posts it has been used with; pretty sure that needs backend implementation as well eh?

Member

novaugust commented Oct 7, 2014

The UI suggests stuff I'm not sure is implemented on the backend yet - things like tag hierarchy, and tags having customizable slugs. Can anyone tell me whether I need to open another issue for that? @halfdan @sebgie @ErisDS

There's also the idea that a tag should report back how many posts it has been used with; pretty sure that needs backend implementation as well eh?

@sebgie

This comment has been minimized.

Show comment
Hide comment
@sebgie

sebgie Oct 7, 2014

Contributor

@novaugust Only tags.browse is implemented atm. All other api endpoints need an issue.

Contributor

sebgie commented Oct 7, 2014

@novaugust Only tags.browse is implemented atm. All other api endpoints need an issue.

@novaugust novaugust changed the title from Implement Tag Management UI in Ember to Implement Tag Management UI Oct 7, 2014

@novaugust

This comment has been minimized.

Show comment
Hide comment
@novaugust

novaugust Oct 7, 2014

Member

@sebgie updated the issue description, let me know what you think

Member

novaugust commented Oct 7, 2014

@sebgie updated the issue description, let me know what you think

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 7, 2014

Member

The way I had thought to do this was to implement the tag management UI only for the features that we do support, and then raise separate issues for adding new features (like hierarchy, visibility, etc)

Member

ErisDS commented Oct 7, 2014

The way I had thought to do this was to implement the tag management UI only for the features that we do support, and then raise separate issues for adding new features (like hierarchy, visibility, etc)

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Oct 8, 2014

Member

Who can do what with tags? cc @JohnONolan

I'm thinking Editor+ can see/manage all aspects of this screen.

NB: That modal screenshot above is outdated, this UI will now exist within a slide-out settings menu.

Member

JohnONolan commented Oct 8, 2014

Who can do what with tags? cc @JohnONolan

I'm thinking Editor+ can see/manage all aspects of this screen.

NB: That modal screenshot above is outdated, this UI will now exist within a slide-out settings menu.

@novaugust

This comment has been minimized.

Show comment
Hide comment
@novaugust

novaugust Oct 8, 2014

Member

Cool, and so authors can neither interact nor see?

On Wed, Oct 8, 2014 at 2:38 AM, JohnONolan notifications@github.com wrote:

Who can do what with tags? cc @JohnONolan https://github.com/JohnONolan

I'm thinking Editor+ can see/manage all aspects of this screen.

NB: That modal screenshot above is outdated, this UI will now exist within
a slide-out settings menu.


Reply to this email directly or view it on GitHub
#4248 (comment).

Member

novaugust commented Oct 8, 2014

Cool, and so authors can neither interact nor see?

On Wed, Oct 8, 2014 at 2:38 AM, JohnONolan notifications@github.com wrote:

Who can do what with tags? cc @JohnONolan https://github.com/JohnONolan

I'm thinking Editor+ can see/manage all aspects of this screen.

NB: That modal screenshot above is outdated, this UI will now exist within
a slide-out settings menu.


Reply to this email directly or view it on GitHub
#4248 (comment).

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Oct 8, 2014

Member

Correct!

Member

JohnONolan commented Oct 8, 2014

Correct!

PaulAdamDavis added a commit to PaulAdamDavis/Ghost that referenced this issue Nov 19, 2014

Update Tags Management Markup
References #4248

- Updates the markup & classes for the tag management settings menu, as they've fallen behind now we've renamed the 'right-outlet' to 'settings-menu'

PaulAdamDavis added a commit to PaulAdamDavis/Ghost that referenced this issue Nov 19, 2014

Update Tags Management Markup
References #4248

- Updates the markup & classes for the tag management settings menu, as they've fallen behind now we've renamed the 'right-outlet' to 'settings-menu'

PaulAdamDavis added a commit to PaulAdamDavis/Ghost that referenced this issue Nov 19, 2014

Update Tags Management Markup
References #4248

- Updates the markup & classes for the tag management settings menu, as they've fallen behind now we've renamed the 'right-outlet' to 'settings-menu'

PaulAdamDavis added a commit to PaulAdamDavis/Ghost that referenced this issue Nov 19, 2014

Update Tags Management Markup
References #4248

- Updates the markup & classes for the tag management settings menu, as they've fallen behind now we've renamed the 'right-outlet' to 'settings-menu'

@ErisDS ErisDS changed the title from Implement Tag Management UI to [Feature] Tag Management Nov 19, 2014

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 20, 2014

Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 20, 2014

Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Nov 21, 2014

Member

Further to @JohnONolan's note about the screenshot being outdated, I've updated the main issue with new screenshots. Here's what it looks like now:

Member

ErisDS commented Nov 21, 2014

Further to @JohnONolan's note about the screenshot being outdated, I've updated the main issue with new screenshots. Here's what it looks like now:

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 21, 2014

Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 21, 2014

Save tags on focus-out
Ref #4248
Current bugs
- Saves even if you didn't make changes

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 21, 2014

Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 21, 2014

Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code

novaugust added a commit to novaugust/Ghost that referenced this issue Nov 22, 2014

Save tags on focus-out
Ref #4248
Current bugs
- Saves even if you didn't make changes

@ErisDS ErisDS added this to the Current Backlog milestone Nov 25, 2014

novaugust added a commit to novaugust/Ghost that referenced this issue Dec 9, 2014

novaugust added a commit to novaugust/Ghost that referenced this issue Dec 9, 2014

ErisDS added a commit to ErisDS/Ghost that referenced this issue Jan 1, 2015

Remove the config flag for tag management
issue #4248

- tag management is ready for release, this takes the training wheels off :)
@sorniva

This comment has been minimized.

Show comment
Hide comment
@sorniva

sorniva Jan 4, 2015

Howdy, unsure if this is the place to report it, knowing it is still being worked on.. but I've not been able to find it reported elsewhere.. and was unsure if a new issue/report should be raised.

I use ghost with the "fileStorage: false" option in my config due to the use of ephemeral storage and I noticed when using the tag management panel the section where an image is added has some odd behavior.

Initially there are multiple submit boxes and buttons for what presumably should simply be one box for the URL and a submit button.. But, even more interesting is if one clicks away out of this tag-info section and moves to another tag, and then another tag after that.. the URL boxes and submit buttons keep building up.

If one clicks away to another section, such as 'General' or 'Users' and returns to the 'tags' section to again click on a tag to edit its tag-info section, it returns to the initial errant amount of URL boxes and submit buttons.

this is happening on 0.5.7 with a postgres database and filestorage disabled.

here are some images showing first the initial state, and second what happens after navigating to a few other tags:

tags1

tags3

sorniva commented Jan 4, 2015

Howdy, unsure if this is the place to report it, knowing it is still being worked on.. but I've not been able to find it reported elsewhere.. and was unsure if a new issue/report should be raised.

I use ghost with the "fileStorage: false" option in my config due to the use of ephemeral storage and I noticed when using the tag management panel the section where an image is added has some odd behavior.

Initially there are multiple submit boxes and buttons for what presumably should simply be one box for the URL and a submit button.. But, even more interesting is if one clicks away out of this tag-info section and moves to another tag, and then another tag after that.. the URL boxes and submit buttons keep building up.

If one clicks away to another section, such as 'General' or 'Users' and returns to the 'tags' section to again click on a tag to edit its tag-info section, it returns to the initial errant amount of URL boxes and submit buttons.

this is happening on 0.5.7 with a postgres database and filestorage disabled.

here are some images showing first the initial state, and second what happens after navigating to a few other tags:

tags1

tags3

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Jan 4, 2015

Member

@Lemur3 That's really odd but it is easy to reproduce it. Could you possibly raise it as a bug? That way it's easier to track, thanks 👍

Member

ErisDS commented Jan 4, 2015

@Lemur3 That's really odd but it is easy to reproduce it. Could you possibly raise it as a bug? That way it's easier to track, thanks 👍

ErisDS added a commit to ErisDS/Ghost that referenced this issue Jan 6, 2015

Tag management no longer behind config/labs flags
issue #4248

- tag management is ready for release, this takes the training wheels off :)
- remove config flag
- remove labs checkbox and related code

ErisDS added a commit to ErisDS/Ghost that referenced this issue Jan 6, 2015

Move tag management from behind config/labs flags
issue #4248

- tag management is ready for release, this takes the training wheels off :)
- remove config flag
- remove labs checkbox and related code
@MaluNoPeleke

This comment has been minimized.

Show comment
Hide comment
@MaluNoPeleke

MaluNoPeleke Jan 13, 2015

Could you please also add this kind of tag list to the editor so that it is easier to use existing tags for new posts?

Could you please also add this kind of tag list to the editor so that it is easier to use existing tags for new posts?

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Jan 13, 2015

Member

@MaluNoPeleke there is already a tag suggestions box in the editor - if you start typing it will pop up:

Member

ErisDS commented Jan 13, 2015

@MaluNoPeleke there is already a tag suggestions box in the editor - if you start typing it will pop up:

@MaluNoPeleke

This comment has been minimized.

Show comment
Hide comment
@MaluNoPeleke

MaluNoPeleke Jan 13, 2015

I know but if I don't remember which tags I have used for a similar post I have to search them by entering different letters which is not very user friendly.
Wordpress for example offers a list of the most used tags in a word cloud.

I know but if I don't remember which tags I have used for a similar post I have to search them by entering different letters which is not very user friendly.
Wordpress for example offers a list of the most used tags in a word cloud.

@ErisDS ErisDS referenced this issue Jan 13, 2015

Closed

[Feature] Advanced Tag Management #4798

8 of 11 tasks complete
@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Jan 13, 2015

Member

Now that 0.5.8 is released, we've achieved the basic tag management feature laid out in this issue. Therefore I'm closing this in favour of #4798.

Member

ErisDS commented Jan 13, 2015

Now that 0.5.8 is released, we've achieved the basic tag management feature laid out in this issue. Therefore I'm closing this in favour of #4798.

@ErisDS ErisDS closed this Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment