Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sitemap XSL #4555

Closed
ErisDS opened this issue Dec 1, 2014 · 3 comments · Fixed by #4562
Closed

Add Sitemap XSL #4555

ErisDS opened this issue Dec 1, 2014 · 3 comments · Fixed by #4562
Assignees
@ErisDS
Labels
server / core Issues relating to the server or core of Ghost
Milestone
Current Backlog

Comments

@ErisDS
Copy link
Member

ErisDS commented Dec 1, 2014

Following on from the epic merge of #623, let's add a nice XSL stylesheet to make the sitemap pretty.

Demo: http://marketplace.ghost.org/sitemap.xml

Note: I've got the wiring done locally & am just awaiting some style guidance from @JohnONolan
@ErisDS ErisDS added the server / core Issues relating to the server or core of Ghost label Dec 1, 2014
@ErisDS ErisDS self-assigned this Dec 1, 2014
@ErisDS ErisDS added this to the Current Backlog milestone Dec 1, 2014
@ErisDS
Copy link
Member Author

ErisDS commented Dec 1, 2014

Template added in #4559

@jgable
Copy link
Contributor

jgable commented Dec 1, 2014

👍 I'm glad you're gonna do this. I thought about it, but I didn't want to slow down the original PR.

@ErisDS
Copy link
Member Author

ErisDS commented Dec 1, 2014

@jgable I didn't want to add YAT to that PR either, especially one which might have some design to-and-fro, so figured it best to do it separately :)

@ErisDS ErisDS mentioned this issue Dec 1, 2014
Merged
ErisDS added a commit to ErisDS/Ghost that referenced this issue Dec 4, 2014
@ErisDS
Add XSL for Sitemaps
818085f 
fixes TryGhost#4555

- There's no easy way to declare an XSL with the node xml module, so I
  needed to move the declarations to both be strings
- Ideally the code to serve the XSL would also be inside the sitemap
  module, but I think we need to refactor a bit to get there easily
- Added the XSL from TryGhost#4559, with minor amends to make the tables and urls
  display correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErisDS ErisDS

Labels
server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
Current Backlog
Development

Successfully merging a pull request may close this issue.

Add XSL for Sitemaps ErisDS/Ghost
2 participants
@ErisDS @jgable