Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Zelda Audit #5652
Followup of #5314
ALL TESTED IN SAFARI 8.0.7 for OSX - I am actively working on these issues
Loading buttons: Don't know how to solve
When an action takes more than 1s, the loading spinner makes sense in a button. But when an action takes 0.1s - adding/removing a loading spinner makes the button feel broken. I think we need a mandatory "success" animation which can follow the loading animation when the route is not changing. I don't think this is going to be easy.
Also: When logging in, the loading button stops spinning before the admin loads. This should not happen. It should keep spinning all the way until the route changes without ever stopping
All tested on latest Chrome for iOS
@JohnONolan the reason the width of the publish button is being set with JS is because when the spinner is activated on post save, the width of the button will shrink to the size of the spinner. This can be removed; however, I didn't have any other good ideas on what to do to prevent the button from shrinking when the spinner is active.
@acburdine The way we handle this on Ghost.org is that when a loading-button is clicked:
(so width is only fixed when it needs to be, not all the time)