Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag delete button has broken styles #8345

Closed
kevinansfield opened this issue Apr 17, 2017 · 0 comments · Fixed by TryGhost/Admin#651
Closed

Tag delete button has broken styles #8345

kevinansfield opened this issue Apr 17, 2017 · 0 comments · Fixed by TryGhost/Admin#651
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Milestone
1.0.0 Beta Ready

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

The styling for the "Delete tag" button at the bottom of the tag settings form is broken.

screen shot 2017-04-17 at 18 04 58

For comparison, here's the same button in 0.11 LTS

screen shot 2017-04-17 at 18 17 44

Technical details:
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly css labels Apr 17, 2017
@kevinansfield kevinansfield added this to the 1.0.0 Beta Ready milestone Apr 17, 2017
@kevinansfield kevinansfield self-assigned this Apr 17, 2017
@kevinansfield kevinansfield mentioned this issue Apr 17, 2017
Merged
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 18, 2017
@kevinansfield
🎨 fix settings menu delete button styles
327ef01 
closes TryGhost/Ghost#8345
- renames `.tag-delete-button` to `.settings-menu-delete-button` to match it's more generic purpose
- match styles as close to 0.11.x as possible, it was necessary to add both stroke and fill to the trashcan SVG for it not to be washed out
@kevinansfield kevinansfield mentioned this issue Apr 18, 2017
Merged
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 19, 2017
@kevinansfield
🎨 fix settings menu delete button styles
05fb835 
closes TryGhost/Ghost#8345
- renames `.tag-delete-button` to `.settings-menu-delete-button` to match it's more generic purpose
- match styles as close to 0.11.x as possible, it was necessary to add both stroke and fill to the trashcan SVG for it not to be washed out
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue Apr 19, 2017
@kevinansfield @kirrg001
🎨 fix settings menu delete button styles (#651)
ae1b5ee 
closes TryGhost/Ghost#8345

- renames `.tag-delete-button` to `.settings-menu-delete-button` to match it's more generic purpose
- match styles as close to 0.11.x as possible, it was necessary to add both stroke and fill to the trashcan SVG for it not to be washed out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
1.0.0 Beta Ready
Development

Successfully merging a pull request may close this issue.

🎨 fix settings menu delete button styles kevinansfield/Ghost-Admin
1 participant
@kevinansfield