Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Allowed overwrite of protocol for canonical URLs #10729

Merged

Conversation

@AileenCGN
Copy link
Member

commented May 6, 2019

closes #10709

  • Only transform a canonical URL that is identical with the Blog URL to a relative URL when the protocol matches as well
  • Leave the canonical URL absolute for all other cases
  • Use case for this is e. g. when users want to port over their Facebook comments/shares/likes after a move from http to https
@AileenCGN AileenCGN requested a review from gargol May 6, 2019
closes #10709

- Only transform a canonical URL that is identical with the Blog URL to a relative URL when the protocol matches as well
- Leave the canonical URL absolute for all other cases
- Use case for this is e. g. when users want to port over their Facebook comments/shares/likes after a move from `http` to `https`
@AileenCGN AileenCGN force-pushed the AileenCGN:allow-mismatched-protocol-canonical-url branch from 631c633 to f267ae5 May 6, 2019
@gargol

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

馃殺 馃殌 馃幐

@gargol gargol merged commit b2ed906 into TryGhost:master May 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.