Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for validator preventing requests without tld #11097

Closed
wants to merge 2 commits into from

Conversation

@ggassmann
Copy link

commented Sep 9, 2019

Use the require_tld: false option in the package validator.

Per https://forum.ghost.org/t/scheduled-posts-wont-publish/8924/7

ggassmann added 2 commits Sep 9, 2019
@ErisDS

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I don't think this is the right fix for the problem - it's changing many, many cases & and usages, to resolve an edge case in one specific usage.

https://forum.ghost.org/t/scheduled-posts-wont-publish/8924/10

As I understand, your use case is very edgecase - not having a TLD - and it's only affecting the scheduler. Therefore it doesn't make sense to change all usages of the request lib and also the generic url validator to solve that one tiny case, when it has the potential to cause hard to understand errors in many other cases.

IMO there are easier, safer solutions that have less impact.

@ErisDS ErisDS closed this Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.