New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Added ability to mark post as a static page #1139

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@egdelwonk
Contributor

egdelwonk commented Oct 17, 2013

closes #969

  • Added post type toggle to admin ui
  • Added post type indicator in content list in admin ui
  • Added post type update indicator flash messages
  • Added homepage post type exclusion (exclude pages)
@gotdibbs

This comment has been minimized.

Show comment
Hide comment
@gotdibbs

gotdibbs Oct 17, 2013

Member

Hi @egdelwonk! Your PR has failed travis on the jslint tests, please check that out, update and rebase. You can see how we to run the tests from the contributing doc. I would also recommend including screenshots in the issue/PR as to what the UI looks like so your PR can be accepted quicker.

Member

gotdibbs commented Oct 17, 2013

Hi @egdelwonk! Your PR has failed travis on the jslint tests, please check that out, update and rebase. You can see how we to run the tests from the contributing doc. I would also recommend including screenshots in the issue/PR as to what the UI looks like so your PR can be accepted quicker.

@egdelwonk

This comment has been minimized.

Show comment
Hide comment
@egdelwonk

egdelwonk Oct 17, 2013

Contributor

@gotdibbs Sorry about the failures. Had some whitespace issues. Ran all of the tests and they seem to pass locally now.

Here are a few screenshots:


screen shot 2013-10-16 at 10 25 08 pm
screen shot 2013-10-16 at 10 25 31 pm
screen shot 2013-10-16 at 10 26 23 pm
screen shot 2013-10-16 at 10 30 00 pm

Contributor

egdelwonk commented Oct 17, 2013

@gotdibbs Sorry about the failures. Had some whitespace issues. Ran all of the tests and they seem to pass locally now.

Here are a few screenshots:


screen shot 2013-10-16 at 10 25 08 pm
screen shot 2013-10-16 at 10 25 31 pm
screen shot 2013-10-16 at 10 26 23 pm
screen shot 2013-10-16 at 10 30 00 pm

@jgable

This comment has been minimized.

Show comment
Hide comment
@jgable

jgable Oct 17, 2013

Member

Almost there! Can you rebase and squash your commits into one so we can keep a clean history for our change log?

You did a good job on the commit message format though.

Member

jgable commented Oct 17, 2013

Almost there! Can you rebase and squash your commits into one so we can keep a clean history for our change log?

You did a good job on the commit message format though.

@halfdan

This comment has been minimized.

Show comment
Hide comment
@halfdan

halfdan Oct 17, 2013

Member

Oh well. I just finished the implementation of this as well :-( Your changes look great, although I would've preferred a simple toggle button instead of the dropdown.

Edit: I think you rebased too many commits. There are several edits in your commit that are not related to your change.

Member

halfdan commented Oct 17, 2013

Oh well. I just finished the implementation of this as well :-( Your changes look great, although I would've preferred a simple toggle button instead of the dropdown.

Edit: I think you rebased too many commits. There are several edits in your commit that are not related to your change.

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Oct 17, 2013

Member

Ghost has no concept of post type - it only has a concept of "page" which can be true or false. The preferred UI for this would be "Static Page:" with a checkbox

The label implementation on the post overview screen is very nice, but it's overkill for our needs. It should be a much simpler straight replacement of [publication date] with "Static Page" - with no modifications to the the publication date field for posts.

Member

JohnONolan commented Oct 17, 2013

Ghost has no concept of post type - it only has a concept of "page" which can be true or false. The preferred UI for this would be "Static Page:" with a checkbox

The label implementation on the post overview screen is very nice, but it's overkill for our needs. It should be a much simpler straight replacement of [publication date] with "Static Page" - with no modifications to the the publication date field for posts.

@JohnONolan

This comment has been minimized.

Show comment
Hide comment
@JohnONolan

JohnONolan Oct 17, 2013

Member

This PR should also add "page" to {{body_class}} when viewing a page on the front end

Member

JohnONolan commented Oct 17, 2013

This PR should also add "page" to {{body_class}} when viewing a page on the front end

Added ability to mark post as static.
closes #969

- Added post static toggle to admin ui
- Added post static indicator in content list in admin ui
- Added post static update indicator flash messages
- Added homepage static post exclusion
- Added static page body class
@egdelwonk

This comment has been minimized.

Show comment
Hide comment
@egdelwonk

egdelwonk Oct 17, 2013

Contributor

@JohnONolan I've made the changes you've suggested in your comment and updated the commit message to reflect. :)

screen shot 2013-10-17 at 9 00 55 am
screen shot 2013-10-17 at 9 01 14 am
screen shot 2013-10-17 at 9 00 51 am

Contributor

egdelwonk commented Oct 17, 2013

@JohnONolan I've made the changes you've suggested in your comment and updated the commit message to reflect. :)

screen shot 2013-10-17 at 9 00 55 am
screen shot 2013-10-17 at 9 01 14 am
screen shot 2013-10-17 at 9 00 51 am

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 24, 2013

Member

Apologies for taking some time to get to this. I just started looking at your commit and it's full of other changes that aren't to do with this issue. It looks like you rebased a lot of other people's changes?

Your PR is very similar to #1147, with the big difference being you added a different template, which is cool.

Perhaps resubmit with just this feature, but make it optional, so that the frontend only uses the page.hbs template if one is available, and otherwise falls back to using post.hbs. You can use ghost.paths().availableThemes[ghost.settings('activeTheme')] to find out whether the current theme has a page template or not.

Member

ErisDS commented Oct 24, 2013

Apologies for taking some time to get to this. I just started looking at your commit and it's full of other changes that aren't to do with this issue. It looks like you rebased a lot of other people's changes?

Your PR is very similar to #1147, with the big difference being you added a different template, which is cool.

Perhaps resubmit with just this feature, but make it optional, so that the frontend only uses the page.hbs template if one is available, and otherwise falls back to using post.hbs. You can use ghost.paths().availableThemes[ghost.settings('activeTheme')] to find out whether the current theme has a page template or not.

@ErisDS

This comment has been minimized.

Show comment
Hide comment
@ErisDS

ErisDS Oct 26, 2013

Member

I'm closing this as I believe #1147 will be ready shortly. I would really love for you to submit a further PR adding the custom page template feature, so that I can add that along with your PR to Casper.

Member

ErisDS commented Oct 26, 2013

I'm closing this as I believe #1147 will be ready shortly. I would really love for you to submit a further PR adding the custom page template feature, so that I can add that along with your PR to Casper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment