Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature / Added ability to mark post as a static page #1139
Oh well. I just finished the implementation of this as well :-( Your changes look great, although I would've preferred a simple toggle button instead of the dropdown.
Edit: I think you rebased too many commits. There are several edits in your commit that are not related to your change.
Ghost has no concept of post type - it only has a concept of "page" which can be true or false. The preferred UI for this would be "Static Page:" with a checkbox
The label implementation on the post overview screen is very nice, but it's overkill for our needs. It should be a much simpler straight replacement of [publication date] with "Static Page" - with no modifications to the the publication date field for posts.
Apologies for taking some time to get to this. I just started looking at your commit and it's full of other changes that aren't to do with this issue. It looks like you rebased a lot of other people's changes?
Your PR is very similar to #1147, with the big difference being you added a different template, which is cool.
Perhaps resubmit with just this feature, but make it optional, so that the frontend only uses the page.hbs template if one is available, and otherwise falls back to using post.hbs. You can use