Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #12735

Closed
wants to merge 1 commit into from
Closed

fix typo #12735

wants to merge 1 commit into from

Conversation

makeitworks
Copy link

i think this is a typo

@ErisDS ErisDS self-assigned this Mar 5, 2021
@ErisDS
Copy link
Member

ErisDS commented Mar 5, 2021

It is, but the return value is not used. Would be better to change this to just return;

@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Jun 3, 2021
@stale stale bot closed this Jun 11, 2021
ErisDS added a commit that referenced this pull request Jun 23, 2021
refs: #12735

- this property doesn't exist - it should be this.resourcesConfig
- but we don't use the return value, so simply removed it
@ErisDS
Copy link
Member

ErisDS commented Jun 23, 2021

I made this change here: c12edf4

@ErisDS ErisDS removed their assignment Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants