Skipped flaky welcome emails test

[cmraible]

ref https://linear.app/ghost/issue/NY-1234/flaky-member-welcome-emails-e2e-test

This test has been flaky recently. Skipping it for now to avoid disrupting CI while I work on a fix.

[coderabbitai]

Walkthrough

A Playwright test case in the admin member welcome emails test file is modified to be skipped during test execution. Specifically, the test named "Escape closes welcome email color picker without bypassing unsaved changes confirmation" is converted from an active test to a skipped test by changing the test invocation from test(...) to test.skip(...). The test logic and assertions remain unchanged; only the test execution status is altered.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: skipping a flaky test case in the welcome emails test file.
Description check	✅ Passed	The description is directly related to the changeset, explaining why the test is being skipped and referencing the Linear issue tracking the underlying problem.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-flaky-welcome-emails-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

e2e/tests/admin/settings/member-welcome-emails.test.ts (1)

272-272: Add a tracking reference next to the skip.

The skip has no inline pointer to the Linear issue (NY-1234), which makes it easy to forget. Consider adding a short comment above the test.skip(...) so anyone touching this file later knows why it's skipped and where to track re-enablement.

Proposed change

+    // Skipped due to flakiness — see NY-1234
     test.skip('Escape closes welcome email color picker without bypassing unsaved changes confirmation', async ({page}) => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@e2e/tests/admin/settings/member-welcome-emails.test.ts` at line 272, Add an
inline tracking reference comment immediately above the test.skip call for the
test named 'Escape closes welcome email color picker without bypassing unsaved
changes confirmation' so future editors know why it's skipped and where to track
re-enablement (e.g., "TODO: skipped due to NY-1234 - re-enable when ...").
Update the comment to include the Linear issue ID (NY-1234) and a brief one-line
reason or owner; leave the test.skip(...) call unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@e2e/tests/admin/settings/member-welcome-emails.test.ts`:
- Line 272: Add an inline tracking reference comment immediately above the
test.skip call for the test named 'Escape closes welcome email color picker
without bypassing unsaved changes confirmation' so future editors know why it's
skipped and where to track re-enablement (e.g., "TODO: skipped due to NY-1234 -
re-enable when ..."). Update the comment to include the Linear issue ID
(NY-1234) and a brief one-line reason or owner; leave the test.skip(...) call
unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7abb6123-0826-4e19-b740-296fd5e4a03c

📥 Commits

Reviewing files that changed from the base of the PR and between 12b7357 and a9d4bbd.

📒 Files selected for processing (1)

• e2e/tests/admin/settings/member-welcome-emails.test.ts

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud