🐛 Fixed missing favicons in Ghost Admin

[jonatansberg]

Summary

Moved the Ghost Admin favicon and Apple touch icon from apps/admin/public into apps/admin/src, this lets Vite process, hash, and rewrite the favicon URLs with the same path handling as the rest of the admin assets.

Context

The previous favicon change moved the links into apps/admin/index.html, but the icons remained effectively static assets for the admin build path. On production Admin pages this could leave the rendered favicon URL pointing at an asset that was not present in the final served admin bundle, causing /ghost/assets/img/favicon.ico to 404.

Verification

• pnpm --filter @tryghost/admin build reaches Vite emission and confirms the icons are emitted as hashed assets:
  • dist/assets/favicon-C_q1KHzv.ico
  • dist/assets/apple-touch-icon-DhO18_4B.png
• manually verified the Vite dev server rewrites the relative source hrefs to the configured admin base and serves /__admin-dev__/src/assets/img/favicon.ico with 200

ref https://linear.app/ghost/issue/ONC-1812/oss-issue-site-favicons-not-showing-inside-ghost-admin

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7be8cbf8-03a2-4768-a44c-ee4e6e31b992

📥 Commits

Reviewing files that changed from the base of the PR and between 049e4e2 and b2d7f5e.

⛔ Files ignored due to path filters (2)

• apps/admin/src/assets/img/apple-touch-icon.png is excluded by !**/*.png
• apps/admin/src/assets/img/favicon.ico is excluded by !**/*.ico

📒 Files selected for processing (1)

• apps/admin/index.html

---

Walkthrough

This PR updates the favicon and Apple touch icon link paths in apps/admin/index.html. The href attributes on lines 17–18 are changed from relative paths (assets/img/...) to absolute paths (/src/assets/img/...), aligning the asset references with the updated directory structure.

Possibly related PRs

• TryGhost/Ghost#27528: Directly overlaps with changes to apps/admin/index.html icon link tags, including the Apple touch icon href path adjustment.

Suggested labels

needs:review

Suggested reviewers

• rob-ghost

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing missing favicons in Ghost Admin, which aligns with the changeset that relocates favicon files to ensure proper Vite processing.
Description check	✅ Passed	The description is directly related to the changeset, providing clear context about moving favicon assets from apps/admin/public to apps/admin/src and explaining the technical rationale and verification steps.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch onc-1812-admin-favicon

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}