Targeted explore settings more directly in Growth settings#28418
Conversation
towards https://linear.app/ghost/issue/NY-1321 *This change should have no user impact.* Before this change, we fetched an array of settings but only grabbed the first. After this change, we just fetch the setting we need. I think this is useful on its own, but also makes [an upcoming change][0] easier. [0]: https://linear.app/ghost/issue/NY-1321
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates the explore settings component to change how two boolean configuration values are retrieved from the settings API. Previously, the component destructured 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
towards https://linear.app/ghost/issue/NY-1321
This change should have no user impact.
Before this change, we fetched an array of settings but only grabbed the first. After this change, we just fetch the setting we need.
I think this is useful on its own, but also makes an upcoming change easier.