Skip to content

Targeted explore settings more directly in Growth settings#28418

Merged
EvanHahn merged 1 commit into
mainfrom
fetch-just-one-setting-value-in-growth-admin-settings-section
Jun 8, 2026
Merged

Targeted explore settings more directly in Growth settings#28418
EvanHahn merged 1 commit into
mainfrom
fetch-just-one-setting-value-in-growth-admin-settings-section

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

towards https://linear.app/ghost/issue/NY-1321

This change should have no user impact.

Before this change, we fetched an array of settings but only grabbed the first. After this change, we just fetch the setting we need.

I think this is useful on its own, but also makes an upcoming change easier.

towards https://linear.app/ghost/issue/NY-1321

*This change should have no user impact.*

Before this change, we fetched an array of settings but only grabbed the
first. After this change, we just fetch the setting we need.

I think this is useful on its own, but also makes [an upcoming
change][0] easier.

[0]: https://linear.app/ghost/issue/NY-1321
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1f71ea34-0dba-400d-bcd8-375c4ac5865f

📥 Commits

Reviewing files that changed from the base of the PR and between 642b2a1 and 2ad69b6.

📒 Files selected for processing (1)
  • apps/admin-x-settings/src/components/settings/growth/explore.tsx

Walkthrough

This PR updates the explore settings component to change how two boolean configuration values are retrieved from the settings API. Previously, the component destructured explore_ping and explore_ping_growth from results returned by getSettingValues(). The change introduces getSettingValue() as an import and refactors the component to retrieve each boolean setting individually via separate getSettingValue() calls, with explicit Boolean() coercion applied to each result. The rendering logic that consumes these values remains unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: refactoring to fetch explore settings more directly using getSettingValue instead of destructuring from getSettingValues array.
Description check ✅ Passed The description is directly related to the changeset, explaining the refactoring from fetching an array of settings to fetching a single specific setting, which aligns with the code changes in explore.tsx.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fetch-just-one-setting-value-in-growth-admin-settings-section

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn merged commit ceb2254 into main Jun 8, 2026
48 checks passed
@EvanHahn EvanHahn deleted the fetch-just-one-setting-value-in-growth-admin-settings-section branch June 8, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant