Skip to content

Updated timezone-data package#28419

Merged
9larsons merged 2 commits into
mainfrom
upd-timezone
Jun 8, 2026
Merged

Updated timezone-data package#28419
9larsons merged 2 commits into
mainfrom
upd-timezone

Conversation

@9larsons

@9larsons 9larsons commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

ref #24562

@9larsons 9larsons enabled auto-merge (squash) June 8, 2026 15:53
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b62c151c-4968-420c-82a4-9664140a7dc0

📥 Commits

Reviewing files that changed from the base of the PR and between 9c6ef3a and a01d609.

📒 Files selected for processing (1)
  • ghost/admin/tests/integration/services/config-test.js

Walkthrough

This PR updates the @tryghost/timezone-data dependency catalog entry in pnpm-workspace.yaml from 0.4.20 to 0.5.0 and adjusts an integration test in ghost/admin/tests/integration/services/config-test.js to expect 70 timezones (was 67).

Possibly related PRs

  • TryGhost/Ghost#27886: Also updates the @tryghost/timezone-data catalog entry in pnpm-workspace.yaml.

Suggested reviewers

  • EvanHahn
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Updated timezone-data package' directly and clearly summarizes the main change in the changeset - upgrading the @tryghost/timezone-data dependency from 0.4.20 to 0.5.0.
Description check ✅ Passed The description 'ref #24562' is directly related to the changeset, referencing the issue that prompted the timezone-data package update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upd-timezone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- timezone-data 0.5.0 adds 3 new zones (67 -> 70), so the hardcoded length assertion needed updating to match
@9larsons 9larsons merged commit 1c9afe0 into main Jun 8, 2026
98 of 101 checks passed
@9larsons 9larsons deleted the upd-timezone branch June 8, 2026 18:15
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.72%. Comparing base (133a5f0) to head (a01d609).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28419      +/-   ##
==========================================
- Coverage   73.76%   73.72%   -0.05%     
==========================================
  Files        1539     1539              
  Lines      131081   131178      +97     
  Branches    15700    15707       +7     
==========================================
+ Hits        96697    96709      +12     
- Misses      33394    33479      +85     
  Partials      990      990              
Flag Coverage Δ
admin-tests 54.67% <ø> (ø)
e2e-tests 73.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant