Removed unused timezones mirage fixture#28422
Merged
Merged
Conversation
ref #24536 - mirage/fixtures/timezones.js is dead code: admin reads timezones directly from the @tryghost/timezone-data package (app/instance-initializers/config.js), so the list never goes through the API and there is nothing for mirage to mock - no mirage route or scenario loads the fixture; it was orphaned when the config initializer moved to importing the package and has only drifted since - removing it instead of hand-maintaining it to match timezone-data, which is what #24562 attempted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ghost/admin/mirage/fixtures/timezones.js, which is dead code.The admin reads the timezone list directly from the
@tryghost/timezone-datapackage inapp/instance-initializers/config.js(availableTimezones), so the list never goes through the API. No mirage route or scenario loads this fixture — it was orphaned when the config initializer moved to importing the package directly, and has only drifted out of date since.Keeping it around just invites pointless maintenance to chase the real package (e.g. #24562, which hand-edited it to track timezone-data 0.5.0 and still didn't match the shipped data). Deleting it is the cleaner fix.
ref #24536