Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial client unit test. #4527

Merged
merged 1 commit into from Nov 27, 2014
Merged

Add initial client unit test. #4527

merged 1 commit into from Nov 27, 2014

Conversation

@rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Nov 27, 2014

Adds basic client unit testing setup using ember-mocha.

There are many example blueprints for unit tests using ember-cli-mocha here. These are written for Ember CLI, but apply nearly the same here.

My hope is that this is just the beginning of many unit tests for the admin client.


Running testem in the root of the project brings up the testem runner:

screenshot

Navigating to http://localhost:7357/core/test/client/index.html then shows the browser tests:

screenshot

Addresses #2990.


p.s. Sorry it took me so long...

@rwjblue rwjblue force-pushed the rwjblue:unit-tests branch to ef71d93 Nov 27, 2014
@@ -769,7 +815,7 @@ var _ = require('lodash'),
// details of each of the test suites.
//
grunt.registerTask('test', 'Run tests and lint code',
['jshint', 'jscs', 'test-routes', 'test-module', 'test-unit', 'test-integration', 'test-functional']);
['jshint', 'jscs', 'test-routes', 'test-module', 'test-unit', 'test-integration', 'test-functional', 'shell:testem']);

This comment has been minimized.

@jaswilli

jaswilli Nov 27, 2014
Contributor

Would there be any reason why the testem tests couldn't run before the functional tests? They're so slow it's nice to have them go last.

@jaswilli
Copy link
Contributor

@jaswilli jaswilli commented Nov 27, 2014

Awesome. 🎉

@ErisDS
Copy link
Member

@ErisDS ErisDS commented Nov 27, 2014

So much epic 🎊 🎈 🍰

@rwjblue THANK YOU soooooooo much for taking the time to do this 😁
@jaswilli I totally agree - but I think this is going to be the trigger for a few restructuring changes to the tests and we can do that separately :)

ErisDS added a commit that referenced this pull request Nov 27, 2014
Add initial client unit test.
@ErisDS ErisDS merged commit 1db30f8 into TryGhost:master Nov 27, 2014
1 check passed
1 check passed
@JohnONolan
continuous-integration/travis-ci The Travis CI build passed
Details
@rwjblue rwjblue deleted the rwjblue:unit-tests branch Nov 27, 2014
@ErisDS ErisDS mentioned this pull request Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants