Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ObjectController proxying behavior. #4748

Merged
merged 1 commit into from Jan 2, 2015

Conversation

@rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Jan 2, 2015

No issue.

Ember.ObjectController (and Ember.ArrayController) will be deprecated in Ember 1.11 (and removed from core in Ember 2.0). The reasoning is detailed in the Ember 2.0 RFC.

This PR does the following:

  • Updates templates/controllers/views to explicitly reference model properties (instead of relying on proxying behavior).
  • Clearly delineate where certain properties are being set or retrieved from (for example it was not clear exactly where scratch and titleScratch were stored).
  • Remove usage of Ember.ObjectController.
  • Add JSCS rule to prevent future PR's from adding regressions.

References:

Ember.ObjectController (and Ember.ArrayController) will be deprecated in
Ember 1.11 (and removed from core in Ember 2.0). The reasoning is
detailed in the Ember 2.0 RFC.

This PR does the following:

* Updates templates/controllers/views to explicitly reference model
  properties (instead of relying on proxying behavior).
* Clearly delineate where certain properties are being set or retrieved
  from (for example it was not clear exactly where `scratch` and
  `titleScratch` were stored).
* Remove usage of `Ember.ObjectController`.
* Add JSCS rule to prevent future PR's from adding regressions.
@rwjblue
Copy link
Contributor Author

@rwjblue rwjblue commented Jan 2, 2015

To test the deprecation in emberjs/ember.js#10062 I also confirmed that with these changes (and the last couple of PR's I submitted) the Ghost test suite passes properly on Ember canary (which will ultimately be 1.11) and Ember 1.10.0-beta.3.

Loading

@wycats
Copy link

@wycats wycats commented Jan 2, 2015

Great work @rwjblue 😄

Loading

@jaswilli
Copy link
Contributor

@jaswilli jaswilli commented Jan 2, 2015

Awesome. Will review tomorrow 😄

Loading

jaswilli added a commit that referenced this issue Jan 2, 2015
Remove ObjectController proxying behavior.
@jaswilli jaswilli merged commit ac5d98e into TryGhost:master Jan 2, 2015
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants