Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 1.13 #5468

Merged
merged 1 commit into from Jun 25, 2015
Merged

Ember 1.13 #5468

merged 1 commit into from Jun 25, 2015

Conversation

@jaswilli
Copy link
Contributor

@jaswilli jaswilli commented Jun 22, 2015

Update to Ember 1.13.2. The highlights:

  • No more views. All views have been converted to components or refactored away.
  • ArrayController/ItemController usage has been converted to regular controllers and components.
  • Deprecated Ember.Select no longer used, replaced with a new component (gh-select-native).
@halfdan
Copy link
Contributor

@halfdan halfdan commented Jun 22, 2015

@jaswilli Epic job! 👍

Loading

// this.get('parentView.controller').send('addTag',
// this.get('suggestion.tag'));
// }
// }),

This comment has been minimized.

Loading

This comment has been minimized.

Loading

@jaswilli
Copy link
Contributor Author

@jaswilli jaswilli commented Jun 24, 2015

Commits squashed.

Loading

@halfdan
Copy link
Contributor

@halfdan halfdan commented Jun 24, 2015

Squeeeee! Merge this magic beast :)

Loading

@ErisDS
Copy link
Member

@ErisDS ErisDS commented Jun 24, 2015

I have taken this for a spin and it seems a-ok. Not sure what caused the merge conflict, much sorry if I merged something I shouldn't. If you update will ensure this goes in next.

Loading

- Refactor to handle deprecations including removal of
  all Views, ArrayControllers, and ItemControllers.
@jaswilli
Copy link
Contributor Author

@jaswilli jaswilli commented Jun 24, 2015

Rebased.

Loading

ErisDS added a commit that referenced this issue Jun 25, 2015
@ErisDS ErisDS merged commit 6836578 into TryGhost:master Jun 25, 2015
1 check passed
Loading
@jaswilli jaswilli deleted the ember-1.13 branch Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants