Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 1.13 #5468

Merged
merged 1 commit into from Jun 25, 2015

Conversation

@jaswilli
Copy link
Member

commented Jun 22, 2015

Update to Ember 1.13.2. The highlights:

  • No more views. All views have been converted to components or refactored away.
  • ArrayController/ItemController usage has been converted to regular controllers and components.
  • Deprecated Ember.Select no longer used, replaced with a new component (gh-select-native).
@halfdan

This comment has been minimized.

Copy link
Member

commented Jun 22, 2015

@jaswilli Epic job! 👍

// this.get('parentView.controller').send('addTag',
// this.get('suggestion.tag'));
// }
// }),

This comment has been minimized.

Copy link
@halfdan

halfdan Jun 22, 2015

Member

Remove?

This comment has been minimized.

Copy link
@jaswilli

jaswilli Jun 22, 2015

Author Member

Eventually (soon). The tag input widget is going to be reimplemented, so I did enough to clear the deprecation warnings on the existing implementation and then left it there as a reference.

this.set('topNotificationCount', count);
},

toggleAutoNav () {
toggleAutoNav: function () {

This comment has been minimized.

Copy link
@halfdan

halfdan Jun 22, 2015

Member

Any reason for switching this back to the verbose syntax?

This comment has been minimized.

Copy link
@jaswilli

jaswilli Jun 22, 2015

Author Member

I don't have any issue with the shortcut syntax but:

  1. That goes against our existing style (no space between function name and parentheses), but the linter isn't yet smart enough to handle that particular bit of ES6 sugar.
  2. We haven't had any actual discussion about what parts of ES6 we're going to use, what the style preferences will be and how that relates to the backend where we're still (realistically) stuck with ES5.

So for now I just reverted the few instances of these types of declarations. I'm not asserting any sort of opinion aside from wanting to keep things consistent.

@jaswilli jaswilli force-pushed the jaswilli:ember-1.13 branch Jun 23, 2015

@jaswilli jaswilli force-pushed the jaswilli:ember-1.13 branch Jun 24, 2015

@jaswilli

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2015

Commits squashed.

@halfdan

This comment has been minimized.

Copy link
Member

commented Jun 24, 2015

Squeeeee! Merge this magic beast :)

@ErisDS

This comment has been minimized.

Copy link
Member

commented Jun 24, 2015

I have taken this for a spin and it seems a-ok. Not sure what caused the merge conflict, much sorry if I merged something I shouldn't. If you update will ensure this goes in next.

Update Ember to 1.13.2
- Refactor to handle deprecations including removal of
  all Views, ArrayControllers, and ItemControllers.

@jaswilli jaswilli force-pushed the jaswilli:ember-1.13 branch to 42166c8 Jun 24, 2015

@jaswilli

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2015

Rebased.

ErisDS added a commit that referenced this pull request Jun 25, 2015

@ErisDS ErisDS merged commit 6836578 into TryGhost:master Jun 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jaswilli jaswilli deleted the jaswilli:ember-1.13 branch Jun 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.