Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording for failed invitations alert #5743

Merged
merged 1 commit into from Aug 28, 2015

Conversation

@cobbspur
Copy link
Member

commented Aug 27, 2015

refs #5652

  • adds conditional string for single/plural failed invitations
Fix wording for failed invitations alert
refs #5652

- Use conditional string for single/plural failed invitations
@cobbspur

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2015

The error handling aspect needs a rethink post-Zelda as the user invite process self.store.createRecord() does not appear to capture server errors.

@ErisDS

This comment has been minimized.

Copy link
Member

commented Aug 28, 2015

Raised #5753 to revisit this.

ErisDS added a commit that referenced this pull request Aug 28, 2015
Merge pull request #5743 from cobbspur/invitations
Fix wording for failed invitations alert

@ErisDS ErisDS merged commit 1ac7d2a into TryGhost:master Aug 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ErisDS ErisDS deleted the cobbspur:invitations branch Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.